Review main Merged

54936[BUGFIX] Read TER XML entity value complete

Alexander Opitz CR +2 V +2 Normal +52 −57 updated 12/12/17, 19:45

Commit message

Improve reading the TER XML file while using the php xml extension.
The character data handler could be called multiple times, so we
shouldn't cut previous data away.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Alexander Opitz uploaded patch set 1 12/05/17, 12:50

  2. TYPO3com voted on patch set 1 V +1 12/05/17, 12:57 Completed build in 06m 54s on Tue, 5 Dec, 01:57 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17207

  3. Jörg Bösche voted on patch set 1 CR +1 12/06/17, 10:42

  4. Stefan Neufeind voted on patch set 1 CR +1 12/11/17, 08:16

  5. Stefan Neufeind commented on patch set 1 V +1 12/11/17, 08:20

    It's not that easy to replicate the error (but it should be fine by reading). But verified that importing TER-data (still) works.
  6. Jigal van Hemert commented on patch set 1 12/11/17, 19:38

    ExtensionXmlPushParser.php:126

    $data is always empty in this function?!
  7. Alexander Opitz voted on patch set 1 CR -1 12/11/17, 19:45

  8. Alexander Opitz rebased onto patch set 2 12/11/17, 19:49

  9. Alexander Opitz commented on patch set 1 12/11/17, 19:50

    ExtensionXmlPushParser.php:126 Reply

    Thanks Jigal, clearing DB completely before import shows this issue. Done
  10. TYPO3com voted on patch set 2 V +1 12/11/17, 19:59 Completed build in 10m 18s on Mon, 11 Dec, 08:59 PM Test Summary: 57117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17594

  11. Alexander Opitz uploaded patch set 3 12/12/17, 08:21

  12. Stefan Neufeind commented on patch set 3 V +1 CR +1 12/12/17, 08:33

    yes, that fix did the trick - verified patchset 1 against 3
  13. TYPO3com voted on patch set 3 V +1 12/12/17, 08:39 Completed build in 17m 45s on Tue, 12 Dec, 09:39 AM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17622

  14. Jigal van Hemert voted on patch set 3 V +2 CR +2 12/12/17, 15:49

  15. Jigal van Hemert merged patch set 4 12/12/17, 19:16

  16. Jigal van Hemert commented on patch set 4 12/12/17, 19:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6ae925a40d4201a58dd37364260b8607589333b5