Review main Merged

54948[TASK] Resolve Todos in InheritancesResolverService

Rico Schueppel CR +2 V +2 Normal +117 −70 updated 02/08/18, 23:02

Commit message

Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Rico Schueppel uploaded patch set 1 12/06/17, 16:50

  2. TYPO3com voted on patch set 1 V -1 12/06/17, 16:50 Completed build in 08s on Wed, 6 Dec, 05:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17246

  3. Mathias Brodala uploaded patch set 2 12/06/17, 17:20

  4. TYPO3com voted on patch set 2 V +1 12/06/17, 17:31 Completed build in 10m 09s on Wed, 6 Dec, 06:31 PM Test Summary: 56997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17254

  5. Reiner Teubner uploaded patch set 3 02/08/18, 13:15

  6. Reiner Teubner commented on patch set 3 02/08/18, 13:16

    rebase merge conflict
  7. TYPO3com voted on patch set 3 V +1 02/08/18, 13:24 Completed build in 08m 38s on Thu, 8 Feb, 02:24 PM Test Summary: 30464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19130

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 02/08/18, 19:13

  9. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/08/18, 21:24

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 02/08/18, 22:56

  11. Christian Kuhn merged patch set 4 02/08/18, 22:56

  12. Christian Kuhn commented on patch set 4 02/08/18, 23:02

    InheritancesResolverService.php:356

    ah foo. i missed that the exception switched back from MissingArrayPathException to this RuntimeException. That's ok for the backport, but not for master.