Review main Merged

54953[FOLLOWUP][FEATURE] Show page translations in list module

Oliver Hader CR +2 V +2 Easy +4 −1 updated 12/07/17, 14:10

Commit message

In case the list module is used for a particular page and
then removing the very same page in the pagetree will lead
to an SQL error since $this->id is null. Using proper
parameter type solves this issue.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 12/06/17, 22:30

  2. TYPO3com voted on patch set 1 V +1 12/06/17, 22:40 Completed build in 09m 44s on Wed, 6 Dec, 11:40 PM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17275

  3. Stefan Neufeind voted on patch set 1 CR +1 12/07/17, 00:25

  4. Benni Mack voted on patch set 1 CR +1 V +1 12/07/17, 14:08

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 12/07/17, 14:10

  6. Gerrit merged patch set 1 12/07/17, 14:10