Review main Abandoned

54969[FOLLOWUP][BUGFIX] EXT:form - Cover empty strings for "skipIfValueIsEmpty"

Mathias Brodala CR 0 V 0 Easy +6 −5 updated 12/07/17, 20:05

Commit message

This ensures that e.g. unchecked checkboxes are not tried to be
stored in the database as empty strings causing an error on int
fields.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 79

  1. Mathias Brodala uploaded patch set 1 12/07/17, 17:10

  2. TYPO3com voted on patch set 1 V +1 12/07/17, 17:20 Completed build in 09m 51s on Thu, 7 Dec, 06:20 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17357

  3. Daniel Gohlke commented on patch set 1 CR -1 12/07/17, 17:31

    Documentation follow up only release in 8.7.
  4. Daniel Gohlke updated the commit message in patch set 2 12/07/17, 17:45

  5. Daniel Gohlke voted on patch set 2 CR +1 V +1 12/07/17, 17:47

  6. TYPO3com voted on patch set 2 V +1 12/07/17, 17:55 Completed build in 09m 20s on Thu, 7 Dec, 06:55 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17358

  7. Björn Jacob voted on patch set 2 CR +1 V +1 12/07/17, 18:16

  8. Björn Jacob voted on patch set 2 CR 0 V 0 12/07/17, 20:05

  9. Mathias Brodala abandoned the change 12/07/17, 20:05

    Wrong branch.