54973[TASK] Move Page Title generation to TSFE
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Susi Moog +1
-
Verified V +2
- Frank Nägler +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-83254-MovedPageGenerationMethodsIntoTSFE.rst1new+39 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php4+120 −6
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+9 −37
- typo3/sysext/frontend/Tests/Unit/Page/PageGeneratorTest.php+11 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+14 −0
Review log 1832
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 12/07/17, 20:08
-
TYPO3com voted on patch set 1 V -1 12/07/17, 20:20 Completed build in 12m 32s on Thu, 7 Dec, 09:20 PM Test Summary: 84 of 57472 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17369
-
Benni Mack uploaded patch set 2 12/07/17, 21:04
-
TYPO3com voted on patch set 2 V -1 12/07/17, 21:18 Completed build in 13m 43s on Thu, 7 Dec, 10:18 PM Test Summary: 84 of 57472 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17373
-
Oliver Klee commented on patch set 2 12/07/17, 22:40
TypoScriptFrontendController.php:3418type hinting and return type hinting -
Benni Mack uploaded patch set 3 12/08/17, 07:08
-
TYPO3com voted on patch set 3 V -1 12/08/17, 07:17 Completed build in 09m 01s on Fri, 8 Dec, 08:17 AM Test Summary: 78 of 57472 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17378
-
Susi Moog uploaded patch set 4 12/08/17, 12:12
-
TYPO3com voted on patch set 4 V -1 12/08/17, 12:25 Completed build in 12m 34s on Fri, 8 Dec, 01:25 PM Test Summary: 1 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17403
-
TYPO3com voted on patch set 4 V +1 12/08/17, 12:39 Completed build in 39m 17s on Fri, 8 Dec, 01:39 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17403
-
Susi Moog voted on patch set 4 CR +1 V +1 12/08/17, 12:40
-
Benni Mack uploaded patch set 5 12/08/17, 15:41
-
TYPO3com voted on patch set 5 V +1 12/08/17, 15:51 Completed build in 10m 04s on Fri, 8 Dec, 04:51 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17419
-
Oliver Klee commented on patch set 5 12/08/17, 15:52
TypoScriptFrontendController.php:3411bool type hinting is missing (2x) -
Benni Mack commented on patch set 6 12/08/17, 16:09
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V -1 12/08/17, 16:25 Completed build in 15m 27s on Fri, 8 Dec, 05:25 PM Test Summary: 68 of 57189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
TYPO3com commented on patch set 6 12/08/17, 16:39 Completed build in 45m 23s on Fri, 8 Dec, 05:39 PM Test Summary: 64 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
TYPO3com commented on patch set 6 12/08/17, 16:52 Completed build in 1h 27m 41s on Fri, 8 Dec, 05:52 PM Test Summary: 64 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
TYPO3com commented on patch set 6 12/08/17, 16:55 Completed build in 2h 13m 05s on Fri, 8 Dec, 05:55 PM Test Summary: 64 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
TYPO3com commented on patch set 6 12/08/17, 17:59 Completed build in 4h 02m 47s on Fri, 8 Dec, 06:59 PM Test Summary: 64 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
TYPO3com commented on patch set 6 12/09/17, 00:05 Completed build in 11h 58m 39s on Sat, 9 Dec, 01:05 AM Test Summary: 64 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17425
-
Benni Mack uploaded patch set 7 12/09/17, 01:34
-
TYPO3com voted on patch set 7 V +1 12/09/17, 01:43 Completed build in 09m 20s on Sat, 9 Dec, 02:43 AM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17438
-
Susi Moog voted on patch set 7 CR +1 V +1 12/09/17, 08:48
-
Georg Ringer commented on patch set 7 12/09/17, 19:03
Deprecation-83254-MovedPageGenerationMethodsIntoTSFE.rst:14please use :php:`...` -
Benni Mack commented on patch set 8 12/09/17, 19:07
Published edit on patch set 7. -
Susi Moog voted on patch set 8 CR +1 V +1 12/09/17, 19:13
-
TYPO3com voted on patch set 8 V +1 12/09/17, 19:17 Completed build in 09m 54s on Sat, 9 Dec, 08:17 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17479
-
Frank Nägler voted on patch set 8 CR +1 12/09/17, 22:46
-
Frank Nägler voted on patch set 8 CR +2 V +2 12/09/17, 22:56
-
Gerrit merged patch set 8 12/09/17, 22:57
-
Markus Klein commented on patch set 9 08/01/18, 21:57
post -1 see small bugTypoScriptFrontendController.php:3384does not work out: https://forge.typo3.org/issues/85720
TypoScriptFrontendController.php:2880