54974[!!!][TASK] Remove config.lockFilePath functionality
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Gorges +1
- Andreas Kienast +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Gorges +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-83256-RemovedLockFilePathFunctionality.rst1new+51 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php1+23 −32
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −8
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
- typo3/sysext/t3editor/Resources/Private/tsref.xml+0 −5
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+0 −1
Review log 1216
-
Benni Mack uploaded patch set 1 12/07/17, 20:44
-
TYPO3com voted on patch set 1 V +1 12/07/17, 20:54 Completed build in 09m 55s on Thu, 7 Dec, 09:54 PM Test Summary: 57129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17370
-
Daniel Gorges voted on patch set 1 CR +1 V +1 12/08/17, 05:49
-
Andreas Kienast commented on patch set 1 CR -1 12/08/17, 07:27
on it -
Andreas Kienast uploaded patch set 2 12/08/17, 07:39
-
TYPO3com voted on patch set 2 V -1 12/08/17, 07:39 Completed build in 12s on Fri, 8 Dec, 08:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17382
-
Andreas Kienast uploaded patch set 3 12/08/17, 07:40
-
Andreas Kienast commented on patch set 3 12/08/17, 07:41
ContentObjectRenderer.php:3086Gut feeling tells me that this must be $possiblePath, because $path is an empty string. Am I correct? -
Benni Mack commented on patch set 4 12/08/17, 07:42
Published edit on patch set 3. -
Andreas Kienast voted on patch set 4 CR +1 12/08/17, 07:47
-
Daniel Gorges voted on patch set 4 CR +1 V +1 12/08/17, 07:47
-
TYPO3com voted on patch set 3 V +1 12/08/17, 07:52 Completed build in 11m 43s on Fri, 8 Dec, 08:52 AM Test Summary: 57105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17383
-
TYPO3com voted on patch set 4 V +1 12/08/17, 07:54 Completed build in 12m 39s on Fri, 8 Dec, 08:55 AM Test Summary: 57105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17384
-
Stefan Neufeind commented on patch set 4 CR +1 V +1 12/08/17, 14:54
"At the same time"Breaking-83256-RemovedLockFilePathFunctionality.rst:12"which was possible" => "which allowed" ... in the sense of "while that option was there (until now)" -
Stefan Neufeind voted on patch set 4 CR +2 V +2 12/08/17, 15:01
-
Gerrit merged patch set 4 12/08/17, 15:01