Review main Merged Breaking

54974[!!!][TASK] Remove config.lockFilePath functionality

Benni Mack CR +2 V +2 Normal +86 −46 updated 12/08/17, 15:01

Commit message

When using the stdWrap.filelist functionality, the lockFilePath
only allowed to be used for a certain directory (usually, if not set, it
was set to fileadmin/), however, this is both very unsecure and inflexible.

Thus, stdWrap.filelist is extended to be used with all local FAL storages.

Add the same time, the public property TSFE->lockFilePath and the TypoScript
option "config.lockFilePath" is removed.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Gorges +1
    • Andreas Kienast +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1216

  1. Benni Mack uploaded patch set 1 12/07/17, 20:44

  2. TYPO3com voted on patch set 1 V +1 12/07/17, 20:54 Completed build in 09m 55s on Thu, 7 Dec, 09:54 PM Test Summary: 57129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17370

  3. Daniel Gorges voted on patch set 1 CR +1 V +1 12/08/17, 05:49

  4. Andreas Kienast commented on patch set 1 CR -1 12/08/17, 07:27

    on it
  5. Andreas Kienast uploaded patch set 2 12/08/17, 07:39

  6. TYPO3com voted on patch set 2 V -1 12/08/17, 07:39 Completed build in 12s on Fri, 8 Dec, 08:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17382

  7. Andreas Kienast uploaded patch set 3 12/08/17, 07:40

  8. Andreas Kienast commented on patch set 3 12/08/17, 07:41

    ContentObjectRenderer.php:3086

    Gut feeling tells me that this must be $possiblePath, because $path is an empty string. Am I correct?
  9. Benni Mack commented on patch set 4 12/08/17, 07:42

    Published edit on patch set 3.
  10. Andreas Kienast voted on patch set 4 CR +1 12/08/17, 07:47

  11. Daniel Gorges voted on patch set 4 CR +1 V +1 12/08/17, 07:47

  12. TYPO3com voted on patch set 3 V +1 12/08/17, 07:52 Completed build in 11m 43s on Fri, 8 Dec, 08:52 AM Test Summary: 57105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17383

  13. TYPO3com voted on patch set 4 V +1 12/08/17, 07:54 Completed build in 12m 39s on Fri, 8 Dec, 08:55 AM Test Summary: 57105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17384

  14. Stefan Neufeind commented on patch set 4 CR +1 V +1 12/08/17, 14:54

    "At the same time"

    Breaking-83256-RemovedLockFilePathFunctionality.rst:12

    "which was possible" => "which allowed" ... in the sense of "while that option was there (until now)"
  15. Stefan Neufeind voted on patch set 4 CR +2 V +2 12/08/17, 15:01

  16. Gerrit merged patch set 4 12/08/17, 15:01