Review main Abandoned Breaking

54979[!!!][TASK] Remove support for relative paths to typo3/

Benni Mack CR 0 V 0 Normal +17 −47 updated 09/29/18, 11:28

Commit message

Only paths relative to PATH_site are allowed in several places,
that is when including a CSS or JS file, also within the Resource Compressor.

Using EXT: syntax is encouraged, however typo3conf/ext/myext/... works
as well.

RST will follow.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 2341

Show 816 earlier messages
  1. Benni Mack uploaded patch set 1 12/08/17, 06:46

  2. TYPO3com voted on patch set 1 V -1 12/08/17, 06:55 Completed build in 09m 23s on Fri, 8 Dec, 07:55 AM Test Summary: 8 of 57472 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17377

  3. Benni Mack uploaded patch set 2 12/09/17, 18:24

  4. TYPO3com voted on patch set 2 V -1 12/09/17, 18:36 Completed build in 11m 59s on Sat, 9 Dec, 07:36 PM Test Summary: 2 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17472

  5. Benni Mack rebased onto patch set 3 12/09/17, 22:40

  6. TYPO3com voted on patch set 3 V -1 12/09/17, 22:55 Completed build in 14m 45s on Sat, 9 Dec, 11:55 PM Test Summary: 2 of 57430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17515

  7. TYPO3com commented on patch set 3 12/09/17, 23:26 Completed build in 1h 01m 09s on Sun, 10 Dec, 12:26 AM Test Summary: 2 of 57430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17515

  8. TYPO3com commented on patch set 3 12/11/17, 04:06 Completed build in 6h 27m 17s on Mon, 11 Dec, 05:06 AM Test Summary: 2 of 57430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17515

  9. Stefan Neufeind commented on patch set 3 12/11/17, 04:10

    didn't find reason of the bamboo-failure :-(
  10. Benni Mack uploaded patch set 4 12/11/17, 05:51

  11. TYPO3com voted on patch set 4 V -1 12/11/17, 06:00 Completed build in 09m 30s on Mon, 11 Dec, 07:01 AM Test Summary: 2 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17542

  12. Benni Mack uploaded patch set 5 12/11/17, 06:28

  13. TYPO3com voted on patch set 5 V +1 12/11/17, 06:37 Completed build in 09m 34s on Mon, 11 Dec, 07:37 AM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17544

  14. Stefan Neufeind commented on patch set 5 CR -1 12/11/17, 06:47

    ResourceCompressor.php:96

    leftover
  15. Benni Mack uploaded patch set 6 12/11/17, 06:48

  16. TYPO3com voted on patch set 6 V +1 12/11/17, 06:58 Completed build in 09m 51s on Mon, 11 Dec, 07:58 AM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17545

  1. Stefan Neufeind commented on patch set 6 12/11/17, 09:26

    maybe add a forge-issue and outline which open points you see (still WIP I guess?)

    ResourceCompressor.php:95

    change to public api
  2. Benni Mack uploaded patch set 7 12/11/17, 21:49

  3. TYPO3com voted on patch set 7 V -1 12/11/17, 22:01 Completed build in 12m 26s on Mon, 11 Dec, 11:01 PM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17606

  4. TYPO3com commented on patch set 7 12/11/17, 22:08 Completed build in 31m 42s on Mon, 11 Dec, 11:08 PM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17606

  5. Oliver Klee commented on patch set 7 12/12/17, 10:14

    Will this be another change request, or is this one then still WIP?
  6. TYPO3com commented on patch set 7 12/15/17, 07:02 Completed build in 9h 44m 38s on Fri, 15 Dec, 08:02 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17606

  7. Benni Mack uploaded patch set 8 02/05/18, 19:42

  8. Wouter Wolters commented on patch set 8 02/05/18, 19:47

    ResourceCompressor.php:96 Unresolved

    var_dump
  9. TYPO3com voted on patch set 8 V +1 02/05/18, 19:54 Completed build in 11m 48s on Mon, 5 Feb, 08:54 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18967

  10. Jörg Bösche uploaded patch set 9 02/06/18, 13:40

  11. TYPO3com voted on patch set 9 V +1 02/06/18, 13:46 Completed build in 06m 14s on Tue, 6 Feb, 02:46 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19014

  12. Benni Mack uploaded patch set 10 03/08/18, 12:51

  13. Benni Mack commented on patch set 10 03/08/18, 12:53

    Functionality using TYPO3_DOCUMENT_ROOT is also a bad idea, IMHO, should go away in the same patch
  14. TYPO3com voted on patch set 10 V +1 03/08/18, 13:02 Completed build in 10m 39s on Thu, 8 Mar, 02:02 PM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20689

  15. Benni Mack uploaded patch set 11 03/09/18, 13:34

  16. TYPO3com voted on patch set 11 V +1 03/09/18, 13:42 Completed build in 08m 43s on Fri, 9 Mar, 02:42 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20742

  17. Oliver Klee commented on patch set 11 03/09/18, 13:54

    Repeating my question: Will this be another change request, or is this one then still WIP?
  18. Benni Mack commented on patch set 11 CR -2 03/09/18, 13:57

    sorry, ful ack, RST missing, but wanted to get it back in shape... RST belongs to this patch of course
  19. Benni Mack uploaded patch set 12 03/20/18, 05:39

  20. TYPO3com voted on patch set 12 V -1 03/20/18, 05:47 Completed build in 08m 07s on Tue, 20 Mar, 06:47 AM Test Summary: 93 of 31034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21706

  21. Benni Mack uploaded patch set 13 03/20/18, 06:58

  22. TYPO3com voted on patch set 13 V -1 03/20/18, 07:09 Completed build in 10m 02s on Tue, 20 Mar, 08:09 AM Test Summary: 39 of 31034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21709

  23. Benni Mack uploaded patch set 14 07/13/18, 17:53

  24. TYPO3com voted on patch set 14 V -1 07/13/18, 18:00 Completed build in 06m 57s on Fri, 13 Jul, 08:00 PM Test Summary: 75 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25383

  25. Benni Mack abandoned the change 09/29/18, 11:28