Review main Merged Breaking

54980[!!!][TASK] Drop support for &id=23.1 (id.type) syntax

Benni Mack CR +2 V +2 Easy +38 −8 updated 12/09/17, 08:46

Commit message

TYPO3 previously allowed to hand over the typeNum parameter
via index.php?id=pageId.typeNum which is dropped now, as
"index.php?id=pageId&type=typeNum" should be used, no more hidden magic.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
  • Verified V +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 12/08/17, 07:11

  2. TYPO3com voted on patch set 1 V +1 12/08/17, 07:21 Completed build in 10m 06s on Fri, 8 Dec, 08:21 AM Test Summary: 57129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17379

  3. Mathias Brodala commented on patch set 1 12/08/17, 08:21

    Rest assured to get a +1/+1 from me. ;-)
  4. Tymoteusz Motylewski commented on patch set 1 12/08/17, 14:25

    lol, did not know that this exist
  5. Benni Mack uploaded patch set 2 12/08/17, 16:43

  6. TYPO3com voted on patch set 2 V +1 12/08/17, 16:53 Completed build in 10m 00s on Fri, 8 Dec, 05:53 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17426

  7. Stefan Neufeind voted on patch set 2 CR +1 V +1 12/08/17, 18:01

  8. Susi Moog voted on patch set 2 CR +2 V +2 12/09/17, 08:46

  9. Gerrit merged patch set 2 12/09/17, 08:46