54983[BUGFIX] Access Close.html from Resources/Public/Html/
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2
- Stefan Neufeind +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 4
Review log 1011
-
Stephan Großberndt uploaded patch set 1 12/08/17, 11:16
-
Stephan Großberndt commented on patch set 1 12/08/17, 11:20
Removing the now unused Resources/Private/Templates/Close.html will be done in a followup for v9 only to be non-breaking. -
TYPO3com voted on patch set 1 V +1 12/08/17, 11:27 Completed build in 10m 55s on Fri, 8 Dec, 12:27 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17398
-
Stephan Großberndt commented on patch set 1 12/08/17, 11:28
The backport for v8/v7 will additionally need to change ExtensionManagementUtility::siteRelPath('backend') . 'Resources/Public/Html/Close.html' to GeneralUtility::getFileAbsFileName('EXT:backend/Resources/Public/Html/Close.html') in shortCutLink() / openInNewWindowLink() which has only been done in master's getCloseUrl() so far. -
Stefan Neufeind commented on patch set 1 12/08/17, 11:35
Do we still need the Private close-template then? For compat maybe? Or not in master anymore but keep it in the backports? Can/should we avoid the separate template-file altogether maybe? Or is there a usecase for having a template here (and being able to override it)? -
Stephan Großberndt commented on patch set 1 12/08/17, 12:28
As I wrote in the first comment to this patch: "Removing the now unused Resources/Private/Templates/Close.html will be done in a followup for v9 only to be non-breaking." This file is not a template. -
Stefan Neufeind voted on patch set 1 CR +1 12/08/17, 12:30
-
Benni Mack voted on patch set 1 CR +2 V +1 12/08/17, 13:30
-
Wouter Wolters voted on patch set 1 CR +1 12/08/17, 13:39
-
Stefan Neufeind voted on patch set 1 CR +2 V +2 12/08/17, 14:31
-
Gerrit merged patch set 1 12/08/17, 14:31