Review main Merged

54995[TASK] Use JsonResponse for all Backend AJAX calls

Benni Mack CR +2 V +2 Hard +103 −155 updated 01/16/18, 12:09

Commit message

The new JsonResponse object should be used throughout the
TYPO3 Backend in order to properly call json_encode() with
the right flags automatically, making the code inside
the controllers simpler.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
  • Verified V +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 69

  1. Benni Mack uploaded patch set 1 12/08/17, 23:11

  2. TYPO3com voted on patch set 1 V -1 12/08/17, 23:21 Completed build in 10m 08s on Sat, 9 Dec, 12:21 AM Test Summary: 14 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17429

  3. TYPO3com commented on patch set 1 12/08/17, 23:26 Completed build in 24m 43s on Sat, 9 Dec, 12:26 AM Test Summary: 11 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17429

  4. Benni Mack uploaded patch set 2 12/08/17, 23:58

  5. TYPO3com voted on patch set 2 V +1 12/09/17, 00:08 Completed build in 09m 56s on Sat, 9 Dec, 01:08 AM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17431

  6. Stefan Neufeind commented on patch set 2 CR +1 V +1 12/09/17, 02:32

    what a beautiful solution :-)
  7. Susi Moog voted on patch set 2 CR +2 V +2 12/09/17, 07:47

  8. Gerrit merged patch set 2 12/09/17, 07:47

  9. Markus Klein commented on patch set 3 01/16/18, 12:09

    followup in https://review.typo3.org/55371, pls check