Review main Merged

54999[BUGFIX] Fix offset and limit in list module

Susi Moog CR +2 V +2 Easy +8 −1 updated 12/09/17, 21:57

Commit message

Offset and limit in a count query do not make sense.

Additionally the hook deprecation was incomplete
as the core also threw deprecation warnings on
list module pagination.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Susi Moog uploaded patch set 1 12/09/17, 15:02

  2. Susi Moog commented on patch set 1 12/09/17, 15:03

    see also https://review.typo3.org/#/c/53940/2 (which was overwritten by the databaseRecordList refactoring)
  3. TYPO3com voted on patch set 1 V +1 12/09/17, 15:12 Completed build in 09m 35s on Sat, 9 Dec, 04:12 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17458

  4. Susi Moog updated the commit message in patch set 2 12/09/17, 15:26

  5. TYPO3com voted on patch set 2 V +1 12/09/17, 15:38 Completed build in 11m 43s on Sat, 9 Dec, 04:38 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17459

  6. Benni Mack voted on patch set 2 CR +1 V +1 12/09/17, 17:25

  7. Benni Mack voted on patch set 2 CR +2 V +2 12/09/17, 21:57

  8. Gerrit merged patch set 2 12/09/17, 21:57

  9. Benni Mack commented on patch set 3 12/09/17, 21:57

    FYI: was a followup from a copy-paste error, so I merged it directly