55020[BUGFIX] Use stateIdentifier instead of Uid for SVG tree nodes
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Alexander Opitz +2
- Stefan Neufeind +1
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js2+35 −18
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/CategoryTreeCest.php1+3 −3
- typo3/sysext/core/Tests/Acceptance/Backend/Page/AddPageInPageModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Template/TemplateCest.php+3 −3
Review log 1521
-
Paweł Rogowicz uploaded patch set 1 12/11/17, 07:03
-
TYPO3com voted on patch set 1 V -1 12/11/17, 07:13 Completed build in 09m 51s on Mon, 11 Dec, 08:13 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17546
-
Paweł Rogowicz uploaded patch set 2 12/11/17, 07:17
-
TYPO3com voted on patch set 2 V -1 12/11/17, 07:27 Completed build in 09m 37s on Mon, 11 Dec, 08:27 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17547
-
Stefan Neufeind commented on patch set 2 12/11/17, 07:45
HTML-structure changed maybe? Bamboo said: CategoryTreeCest: Edit category item Link or Button or CSS or XPath element with '.identifier-0_7 text.node-name' was not found. -
Paweł Rogowicz uploaded patch set 3 12/11/17, 07:47
-
TYPO3com voted on patch set 3 V -1 12/11/17, 07:59 Completed build in 11m 17s on Mon, 11 Dec, 08:59 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17548
-
Paweł Rogowicz uploaded patch set 4 12/11/17, 11:07
-
TYPO3com voted on patch set 4 V +1 12/11/17, 11:18 Completed build in 10m 24s on Mon, 11 Dec, 12:18 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17571
-
Stefan Neufeind commented on patch set 4 V +1 12/11/17, 11:25
SvgTree.js:323space before "create"CategoryTreeCest.php:62nice, should solve possible timing issues during tests maybe -
Paweł Rogowicz uploaded patch set 5 12/11/17, 11:37
-
TYPO3com voted on patch set 5 V +1 12/11/17, 11:47 Completed build in 09m 44s on Mon, 11 Dec, 12:47 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17575
-
Stefan Neufeind commented on patch set 5 V +1 12/11/17, 11:49
revote -
Paweł Rogowicz commented on patch set 4 12/11/17, 12:06
SvgTree.js:323ReplyDone -
Tymoteusz Motylewski commented on patch set 5 CR -1 12/11/17, 13:33
one more tweak to do check whether target exists before accessing it in if (error.target.status || error.target.statusText) { -
Paweł Rogowicz uploaded patch set 6 12/11/17, 13:38
-
TYPO3com voted on patch set 6 V +1 12/11/17, 13:47 Completed build in 09m 47s on Mon, 11 Dec, 02:47 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17577
-
Stefan Neufeind commented on patch set 6 V +1 12/11/17, 14:08
revote -
Tymoteusz Motylewski voted on patch set 6 V +1 CR +1 12/11/17, 14:23
-
Alexander Opitz voted on patch set 6 V +2 CR +2 12/11/17, 14:36
-
Alexander Opitz merged patch set 7 12/11/17, 14:36