Review main Merged

55020[BUGFIX] Use stateIdentifier instead of Uid for SVG tree nodes

Paweł Rogowicz CR +2 V +2 Normal +51 −34 updated 12/11/17, 14:36

Commit message

Change Uid to stateIdentifier because one Uid can occur in the pagetree
many times, for example in DB mounts.
We need to know what node is visible or what node was clicked or what
node was mouse over / mouse leave, e.t.c.

This change also fixes:
- fix MP title position and visibility
- fix changing node name when the same node is multiple in page tree
(pagetree, mount points)
- modified the acceptance tests

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Alexander Opitz +2
    • Stefan Neufeind +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1521

  1. Paweł Rogowicz uploaded patch set 1 12/11/17, 07:03

  2. TYPO3com voted on patch set 1 V -1 12/11/17, 07:13 Completed build in 09m 51s on Mon, 11 Dec, 08:13 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17546

  3. Paweł Rogowicz uploaded patch set 2 12/11/17, 07:17

  4. TYPO3com voted on patch set 2 V -1 12/11/17, 07:27 Completed build in 09m 37s on Mon, 11 Dec, 08:27 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17547

  5. Stefan Neufeind commented on patch set 2 12/11/17, 07:45

    HTML-structure changed maybe? Bamboo said: CategoryTreeCest: Edit category item Link or Button or CSS or XPath element with '.identifier-0_7 text.node-name' was not found.
  6. Paweł Rogowicz uploaded patch set 3 12/11/17, 07:47

  7. TYPO3com voted on patch set 3 V -1 12/11/17, 07:59 Completed build in 11m 17s on Mon, 11 Dec, 08:59 AM Test Summary: 1 of 57418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17548

  8. Paweł Rogowicz uploaded patch set 4 12/11/17, 11:07

  9. TYPO3com voted on patch set 4 V +1 12/11/17, 11:18 Completed build in 10m 24s on Mon, 11 Dec, 12:18 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17571

  10. Stefan Neufeind commented on patch set 4 V +1 12/11/17, 11:25

    SvgTree.js:323

    space before "create"

    CategoryTreeCest.php:62

    nice, should solve possible timing issues during tests maybe
  11. Paweł Rogowicz uploaded patch set 5 12/11/17, 11:37

  12. TYPO3com voted on patch set 5 V +1 12/11/17, 11:47 Completed build in 09m 44s on Mon, 11 Dec, 12:47 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17575

  13. Stefan Neufeind commented on patch set 5 V +1 12/11/17, 11:49

    revote
  14. Paweł Rogowicz commented on patch set 4 12/11/17, 12:06

    SvgTree.js:323 Reply

    Done
  15. Tymoteusz Motylewski commented on patch set 5 CR -1 12/11/17, 13:33

    one more tweak to do check whether target exists before accessing it in if (error.target.status || error.target.statusText) {
  16. Paweł Rogowicz uploaded patch set 6 12/11/17, 13:38

  17. TYPO3com voted on patch set 6 V +1 12/11/17, 13:47 Completed build in 09m 47s on Mon, 11 Dec, 02:47 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17577

  18. Stefan Neufeind commented on patch set 6 V +1 12/11/17, 14:08

    revote
  19. Tymoteusz Motylewski voted on patch set 6 V +1 CR +1 12/11/17, 14:23

  20. Alexander Opitz voted on patch set 6 V +2 CR +2 12/11/17, 14:36

  21. Alexander Opitz merged patch set 7 12/11/17, 14:36