Review TYPO3_8-7 Merged

55028[TASK] EXT:form - improve width of form editor stage

Stefan Neufeind CR +2 V +2 Normal +58 −14 updated 12/11/17, 19:51

Commit message

Improve and expand the width of the form editor stage for different
modes.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Björn Jacob +1
  • Verified V +2
    • Alexander Opitz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1518

  1. Stefan Neufeind uploaded patch set 1 12/11/17, 12:34

  2. Stefan Neufeind commented on patch set 1 CR -1 12/11/17, 12:38

    Manual backport due to cherry-pick-problems with scss; rebuilt CSS can somebody say why I might have different scss-changes and properly rebuild this one please?
  3. TYPO3com voted on patch set 1 V +1 12/11/17, 12:48 Completed build in 13m 53s on Mon, 11 Dec, 01:48 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1494

  4. Stefan Neufeind wrote 12/11/17, 12:48

    Assignee added: Daniel Lorenz <daniel.lorenz@extco.de>
  5. Stefan Neufeind wrote 12/11/17, 12:49

    Assignee changed from: Daniel Lorenz <daniel.lorenz@extco.de> to: Mathias Brodala <mbrodala@pagemachine.de>
  6. Stefan Neufeind wrote 12/11/17, 12:49

    Assignee changed from: Mathias Brodala <mbrodala@pagemachine.de> to: Riccardo De Contardi <erredeco@gmail.com>
  7. Stefan Neufeind wrote 12/11/17, 12:49

    Assignee changed from: Riccardo De Contardi <erredeco@gmail.com> to: Andreas Steiger <typo3@andreassteiger.de>
  8. Stefan Neufeind commented on patch set 1 12/11/17, 12:50

    sorry for changing the assigner back and forth - wanted to add reviewers and used the wrong button
  9. Stefan Neufeind uploaded patch set 2 12/11/17, 13:19

  10. Stefan Neufeind commented on patch set 2 12/11/17, 13:21

    removed all (regenerated) css-files which didn't belong to this patchset. I still don't know why the others seem to have been rebuilt with different optimization-settings, but anyway ...
  11. TYPO3com voted on patch set 2 V +1 12/11/17, 13:30 Completed build in 10m 16s on Mon, 11 Dec, 02:30 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1495

  12. Stefan Neufeind uploaded patch set 3 12/11/17, 14:37

  13. Stefan Neufeind commented on patch set 3 12/11/17, 14:38

    removed my Build/node_modules again and pulled it fresh using yarn; "grunt-cli css" for the rebuild-job - now I only got the form.css modified, as expected. So that build is clean now.
  14. Alexander Opitz voted on patch set 3 V +1 CR +1 12/11/17, 14:45

  15. TYPO3com voted on patch set 3 V +1 12/11/17, 14:46 Completed build in 09m 35s on Mon, 11 Dec, 03:46 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1496

  16. Björn Jacob voted on patch set 3 V +1 CR +1 12/11/17, 15:37

  17. Alexander Opitz voted on patch set 3 V +2 CR +2 12/11/17, 19:43

  18. Alexander Opitz merged patch set 4 12/11/17, 19:51