55028[TASK] EXT:form - improve width of form editor stage
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Björn Jacob +1
-
Verified V +2
- Alexander Opitz +2
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1518
-
Stefan Neufeind uploaded patch set 1 12/11/17, 12:34
-
Stefan Neufeind commented on patch set 1 CR -1 12/11/17, 12:38
Manual backport due to cherry-pick-problems with scss; rebuilt CSS can somebody say why I might have different scss-changes and properly rebuild this one please? -
TYPO3com voted on patch set 1 V +1 12/11/17, 12:48 Completed build in 13m 53s on Mon, 11 Dec, 01:48 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1494
-
Stefan Neufeind wrote 12/11/17, 12:48
Assignee added: Daniel Lorenz <daniel.lorenz@extco.de> -
Stefan Neufeind wrote 12/11/17, 12:49
Assignee changed from: Daniel Lorenz <daniel.lorenz@extco.de> to: Mathias Brodala <mbrodala@pagemachine.de> -
Stefan Neufeind wrote 12/11/17, 12:49
Assignee changed from: Mathias Brodala <mbrodala@pagemachine.de> to: Riccardo De Contardi <erredeco@gmail.com> -
Stefan Neufeind wrote 12/11/17, 12:49
Assignee changed from: Riccardo De Contardi <erredeco@gmail.com> to: Andreas Steiger <typo3@andreassteiger.de> -
Stefan Neufeind commented on patch set 1 12/11/17, 12:50
sorry for changing the assigner back and forth - wanted to add reviewers and used the wrong button -
Stefan Neufeind uploaded patch set 2 12/11/17, 13:19
-
Stefan Neufeind commented on patch set 2 12/11/17, 13:21
removed all (regenerated) css-files which didn't belong to this patchset. I still don't know why the others seem to have been rebuilt with different optimization-settings, but anyway ... -
TYPO3com voted on patch set 2 V +1 12/11/17, 13:30 Completed build in 10m 16s on Mon, 11 Dec, 02:30 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1495
-
Stefan Neufeind uploaded patch set 3 12/11/17, 14:37
-
Stefan Neufeind commented on patch set 3 12/11/17, 14:38
removed my Build/node_modules again and pulled it fresh using yarn; "grunt-cli css" for the rebuild-job - now I only got the form.css modified, as expected. So that build is clean now. -
Alexander Opitz voted on patch set 3 V +1 CR +1 12/11/17, 14:45
-
TYPO3com voted on patch set 3 V +1 12/11/17, 14:46 Completed build in 09m 35s on Mon, 11 Dec, 03:46 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1496
-
Björn Jacob voted on patch set 3 V +1 CR +1 12/11/17, 15:37
-
Alexander Opitz voted on patch set 3 V +2 CR +2 12/11/17, 19:43
-
Alexander Opitz merged patch set 4 12/11/17, 19:51