Review TYPO3_8-7 Merged

55034[TASK] Set composer config platform.php 7.0.0

Christian Kuhn CR +2 V +2 Normal +82 −75 updated 12/11/17, 20:04

Commit message

Similar to what has been done in v7 already, v8 now
sets config.platform.php in composer.json.

See https://getcomposer.org/doc/06-config.md#platform
for more details.

Mind this setting (as all other 'config' section settings)
is only valid for the root composer.json file,
it has no meaning if core is used as dependency in a project
with its own composer.json file. For core however, this setting
is relevant since composer.json is also used as root file
during packaging of standalone core packages.

The setting now effectively prevents core from installing
dependencies that require higher PHP versions, even if the
locally installed PHP version is higher.

The value is set to 7.0.0: Symfony raised PHP requirements
from 7.0.0 to 7.0.8 between 3.3.6 and 3.3.7 versions, setting
7.0.0 as platform.php thus forces downgrade from 3.3.10 to 3.3.6
of symfony dependencies. Wether we raise to 7.0.8 ourselfs for
v8 may be decided with another patch if really needed. This
version downgrade from 3.3.10 to 3.3.6 should be ok since
the upgrade happened with #82834 which has not yet been released
in a stable v8 patch level release.

Composer commands used:

composer config platform.php 7.0.0
composer up symfony/*
composer update --lock

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 12/11/17, 17:20

  2. TYPO3com voted on patch set 1 V +1 12/11/17, 17:34 Completed build in 14m 04s on Mon, 11 Dec, 06:34 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1500

  3. Christian Kuhn updated the commit message in patch set 2 12/11/17, 17:45

  4. TYPO3com voted on patch set 2 V +1 12/11/17, 18:00 Completed build in 14m 50s on Mon, 11 Dec, 07:00 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1501

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/11/17, 19:29

  6. Wouter Wolters voted on patch set 2 CR +1 12/11/17, 19:32

  7. Helmut Hummel commented on patch set 2 V +2 CR +2 12/11/17, 20:04

    For the record. Setting the platform only influneces the packages installed for typo3/cms for development and for the targz release. It does NOT affect composer based installations, where typo3/cms is used as dependency. Also, the Symfony packages we downgraded, work flawlwessly with PHP 7.0.0 as well, even the later versions (3.3.7 and above). the requirement for PHP 7.0.8 was only done to prevent bugs in symfony/form with PHP 7.0.0 to 7.0.7 (see: https://github.com/symfony/symfony/commit/2282a6f895dfa2b0cf8756ccfe992a3101e646f6)
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 12/11/17, 20:04

  9. Christian Kuhn merged patch set 3 12/11/17, 20:04