55034[TASK] Set composer config platform.php 7.0.0
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Helmut Hummel +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Helmut Hummel +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 3
Files 2
Review log 79
-
Christian Kuhn uploaded patch set 1 12/11/17, 17:20
-
TYPO3com voted on patch set 1 V +1 12/11/17, 17:34 Completed build in 14m 04s on Mon, 11 Dec, 06:34 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1500
-
Christian Kuhn updated the commit message in patch set 2 12/11/17, 17:45
-
TYPO3com voted on patch set 2 V +1 12/11/17, 18:00 Completed build in 14m 50s on Mon, 11 Dec, 07:00 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1501
-
Benni Mack voted on patch set 2 V +1 CR +1 12/11/17, 19:29
-
Wouter Wolters voted on patch set 2 CR +1 12/11/17, 19:32
-
Helmut Hummel commented on patch set 2 V +2 CR +2 12/11/17, 20:04
For the record. Setting the platform only influneces the packages installed for typo3/cms for development and for the targz release. It does NOT affect composer based installations, where typo3/cms is used as dependency. Also, the Symfony packages we downgraded, work flawlwessly with PHP 7.0.0 as well, even the later versions (3.3.7 and above). the requirement for PHP 7.0.8 was only done to prevent bugs in symfony/form with PHP 7.0.0 to 7.0.7 (see: https://github.com/symfony/symfony/commit/2282a6f895dfa2b0cf8756ccfe992a3101e646f6) -
Christian Kuhn voted on patch set 2 V +2 CR +2 12/11/17, 20:04
-
Christian Kuhn merged patch set 3 12/11/17, 20:04