55035[TASK] Raise PHP requirement to 7.2.0
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 2
Files 14
- Build/bamboo/src/main/java/core/AbstractCoreSpec.java+2 −2
- Build/bamboo/src/main/java/core/NightlySpec.java+2 −22
- Build/bamboo/src/main/java/core/PreMergeSpec.java+8 −16
- typo3/install/index.php+2 −2
- typo3/sysext/backend/Resources/Private/Php/backend.php+2 −2
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-83289-CoreVersion90NeedsPHP720.rstnew+35 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/frontend/Resources/Private/Php/frontend.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −6
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- typo3/sysext/install/Resources/Private/Php/install.php+2 −2
- composer.json+5 −2
- composer.lock+6 −3
- INSTALL.md1+2 −2
Review log 3448
Show 1623 earlier messages
-
Christian Kuhn uploaded patch set 1 12/11/17, 20:30
-
Christian Kuhn commented on patch set 1 CR -1 12/11/17, 20:30
needs bamboo adjustments before merge. -
TYPO3com voted on patch set 1 V +1 12/11/17, 20:39 Completed build in 09m 34s on Mon, 11 Dec, 09:39 PM Test Summary: 57105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17596
-
Christian Kuhn uploaded patch set 2 12/11/17, 20:44
-
Christian Kuhn uploaded patch set 3 12/11/17, 20:45
-
Frans Saris commented on patch set 3 12/11/17, 20:53
This isn't decided yet is it? -
Christian Kuhn uploaded patch set 4 12/11/17, 20:53
-
TYPO3com voted on patch set 2 V -1 12/11/17, 20:55 Completed build in 11m 31s on Mon, 11 Dec, 09:55 PM Test Summary: 1 of 57448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17598
-
Christian Kuhn uploaded patch set 5 12/11/17, 20:57
-
TYPO3com voted on patch set 3 V -1 12/11/17, 20:58 Completed build in 12m 02s on Mon, 11 Dec, 09:58 PM Test Summary: 1 of 57448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17599
-
Christian Kuhn commented on patch set 5 12/11/17, 20:59
benni will state something on this, frans. -
TYPO3com voted on patch set 4 V -1 12/11/17, 21:04 Completed build in 11m 11s on Mon, 11 Dec, 10:04 PM Test Summary: 983 of 57448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17600
-
TYPO3com voted on patch set 5 V -1 12/11/17, 21:07 Completed build in 09m 22s on Mon, 11 Dec, 10:07 PM Test Summary: 1131 of 57448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17601
-
Christian Kuhn commented on patch set 6 12/11/17, 21:08
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V -1 12/11/17, 21:18 Completed build in 09m 38s on Mon, 11 Dec, 10:18 PM Test Summary: 942 of 57448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17603
-
Christian Kuhn commented on patch set 6 CR -1 12/11/17, 21:35
still on it. -
Christian Kuhn uploaded patch set 7 12/11/17, 21:47
-
TYPO3com voted on patch set 7 V +1 12/11/17, 21:55 Completed build in 08m 19s on Mon, 11 Dec, 10:55 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17605
-
Christian Kuhn voted on patch set 7 V +1 CR +1 12/11/17, 22:00
-
Christian Kuhn commented on patch set 7 12/11/17, 22:02
note: the bamboo plan update has been rolled out already. patches going through pre-merge state will run on php 7.2 only. -
Benjamin Kott commented on patch set 7 V +1 CR +1 12/11/17, 22:19
Not able to test the bamboo stuff, so consider my votes on supporting this desicion. -
Nicole Hummel commented on patch set 7 CR -1 12/11/17, 22:50
On itINSTALL.md:213I guess this change was unintended. -
Nicole Hummel uploaded patch set 8 12/11/17, 23:00
-
Nicole Hummel commented on patch set 8 V +1 CR +1 12/11/17, 23:02
* Removed unintended change in INSTALL.md * Added missing version in typo3/sysext/install/Classes/SystemEnvironment/Check.php -
TYPO3com voted on patch set 8 V -1 12/11/17, 23:08 Completed build in 07m 07s on Tue, 12 Dec, 12:08 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
Christian Kuhn voted on patch set 8 V +1 CR +1 12/11/17, 23:24
-
TYPO3com commented on patch set 8 12/11/17, 23:24 Completed build in 30m 27s on Tue, 12 Dec, 12:24 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
TYPO3com commented on patch set 8 12/11/17, 23:25 Completed build in 54m 54s on Tue, 12 Dec, 12:25 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
TYPO3com commented on patch set 8 12/11/17, 23:26 Completed build in 1h 20m 44s on Tue, 12 Dec, 12:26 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
Christian Kuhn commented on patch set 8 V 0 CR 0 12/11/17, 23:28
no idea why bamboo now consistently fails with the change between version 8 and 9 -
Nicole Hummel commented on patch set 8 12/12/17, 02:04
Tested it manually and there is no error with this patch. But I found another one having exactly the same issue: https://bamboo.typo3.com/browse/CORE-GTC-17606 -
TYPO3com commented on patch set 8 12/12/17, 02:07 Completed build in 4h 26m 48s on Tue, 12 Dec, 03:07 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
TYPO3com commented on patch set 8 12/12/17, 07:02 Completed build in 12h 28m 47s on Tue, 12 Dec, 08:02 AM Test Summary: 1 of 30140 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17610
-
Andreas Kienast commented on patch set 8 12/12/17, 07:35
It looks like the Bamboo failure is caused by not waiting for the AJAX request being finished (and therefore the element the test wants to click does not exist). I don't know how to fix this in a sane way, but this looks like a more general issue. -
Stefan Neufeind voted on patch set 8 CR +1 12/12/17, 07:37
-
Stefan Neufeind commented on patch set 8 CR -1 12/12/17, 07:39
main index.php still has a 7.0.0-check? -
Stefan Neufeind commented on patch set 8 12/12/17, 07:40
same 7.0.0-check for: index.php typo3/index.php typo3/install.php -
Benni Mack commented on patch set 8 12/12/17, 07:48
Stefan, main index.php is built from cms-composer-installers. delete it and do a composer install, it should be re-copied. -
Alexander Opitz voted on patch set 8 V +1 CR +1 12/12/17, 08:03
-
Stefan Neufeind commented on patch set 8 V +1 CR +1 12/12/17, 08:19
thanks, that did the trick -
Susi Moog rebased onto patch set 9 12/12/17, 12:35
-
TYPO3com voted on patch set 9 V +1 12/12/17, 12:56 Completed build in 20m 25s on Tue, 12 Dec, 01:56 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17649
-
Christian Kuhn voted on patch set 9 V +1 CR +1 12/12/17, 12:56
-
Stefan Neufeind voted on patch set 9 V +1 CR +1 12/12/17, 12:57
-
Andreas Kienast voted on patch set 9 CR +1 12/12/17, 13:00
-
Susi Moog voted on patch set 9 V +1 CR +1 12/12/17, 13:00
-
Christian Kuhn voted on patch set 9 V +2 CR +2 12/12/17, 13:00
-
Christian Kuhn merged patch set 10 12/12/17, 13:00