Review main Merged Breaking

55049[!!!][TASK] Upgrade to composer installers 2.0.0

Helmut Hummel CR +2 V +2 Normal +70 −162 updated 12/12/17, 15:39

Commit message

With this step, the typo3/cms package will not be
installable anymore with composer, but only the
single subtree splitted packages like typo3/cms-core.

To ease the usage, a new package typo3/minimal is
introduced, which has dependencies to all required
TYPO3 extensions, so that composer users can't install
an incomplete code base, at least not when using this package.

composer command used:

composer require typo3/cms-composer-installers ^2.0

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2131

Show 36 earlier messages
  1. Helmut Hummel uploaded patch set 1 12/12/17, 14:17

  2. Helmut Hummel updated the commit message in patch set 2 12/12/17, 14:19

  3. Mathias Brodala updated the commit message in patch set 3 12/12/17, 14:20

  4. TYPO3com voted on patch set 1 V -1 12/12/17, 14:28 Completed build in 11m 42s on Tue, 12 Dec, 03:28 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17662

  5. TYPO3com voted on patch set 2 V +1 12/12/17, 14:31 Completed build in 11m 23s on Tue, 12 Dec, 03:31 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17664

  6. TYPO3com voted on patch set 3 V +1 12/12/17, 14:33 Completed build in 13m 06s on Tue, 12 Dec, 03:33 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17665

  1. Benni Mack uploaded patch set 4 12/12/17, 14:54

  2. Benni Mack uploaded patch set 5 12/12/17, 15:02

  3. Christian Kuhn commented on patch set 5 12/12/17, 15:05

    Breaking-83302-ComposerRestrictsInstallationOfTypo3cms.rst:20

    these should be backticks at the end.
  4. Christian Kuhn commented on patch set 5 CR -1 12/12/17, 15:05

    will update
  5. Christian Kuhn commented on patch set 6 12/12/17, 15:06

    Published edit on patch set 5.
  6. TYPO3com voted on patch set 4 V +1 12/12/17, 15:06 Completed build in 11m 27s on Tue, 12 Dec, 04:06 PM Test Summary: 29979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17670

  7. Wouter Wolters voted on patch set 6 CR +1 12/12/17, 15:07

  8. Helmut Hummel commented on patch set 6 CR -2 12/12/17, 15:08

    will update to stable version of installers once they become available on packagist
  9. Christian Kuhn commented on patch set 6 12/12/17, 15:08

    great helmut. was about to ask exactly that. thx :)
  10. Helmut Hummel uploaded patch set 7 12/12/17, 15:09

  11. TYPO3com voted on patch set 7 V -1 12/12/17, 15:09 Completed build in 05s on Tue, 12 Dec, 04:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17674

  12. Helmut Hummel commented on patch set 7 CR 0 12/12/17, 15:10

    done
  13. TYPO3com voted on patch set 5 V +1 12/12/17, 15:12 Completed build in 10m 01s on Tue, 12 Dec, 04:12 PM Test Summary: 29976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17672

  14. TYPO3com voted on patch set 6 V +1 12/12/17, 15:13 Completed build in 07m 32s on Tue, 12 Dec, 04:13 PM Test Summary: 29976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17673

  15. TYPO3com commented on patch set 7 12/12/17, 15:14 Completed build in 01m 50s on Tue, 12 Dec, 04:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17674

  16. Helmut Hummel uploaded patch set 8 12/12/17, 15:16

  17. Helmut Hummel uploaded patch set 9 12/12/17, 15:19

  18. Stefan Neufeind commented on patch set 9 CR +1 12/12/17, 15:21

    read how this is supposed to work and verified (with a "composer install") that it would pull in the 2.0-packages
  19. TYPO3com voted on patch set 8 V +1 12/12/17, 15:25 Completed build in 08m 57s on Tue, 12 Dec, 04:25 PM Test Summary: 29976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17675

  20. TYPO3com voted on patch set 9 V +1 12/12/17, 15:27 Completed build in 08m 44s on Tue, 12 Dec, 04:27 PM Test Summary: 29976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17676

  21. Christian Kuhn voted on patch set 9 V +1 CR +1 12/12/17, 15:28

  22. Helmut Hummel commented on patch set 9 CR -2 12/12/17, 15:31

    qucik check
  23. Helmut Hummel commented on patch set 9 CR 0 12/12/17, 15:36

    ok, I was smart enough back then, so everything works like expected now ;)
  24. Benni Mack voted on patch set 9 V +2 CR +2 12/12/17, 15:39

  25. Benni Mack merged patch set 10 12/12/17, 15:39