Review main Merged

55060[TASK] Salted Passwords: Add a ComposedSaltInterface

Benni Mack CR +2 V +2 Easy +39 −1 updated 12/13/17, 06:55

Commit message

Add another interface, in order to allow to code
against interface instead of abstractions,
so composed salts that implement their own
password-hashing can implement this interface.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Nicole Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 12/12/17, 20:51

  2. TYPO3com voted on patch set 1 V +1 12/12/17, 20:59 Completed build in 07m 56s on Tue, 12 Dec, 09:59 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17694

  3. Oliver Klee voted on patch set 1 CR +1 12/12/17, 21:20

  4. Nicole Hummel voted on patch set 1 V +1 CR +1 12/12/17, 21:35

  5. Stefan Neufeind voted on patch set 1 V +2 CR +2 12/13/17, 06:55

  6. Stefan Neufeind merged patch set 2 12/13/17, 06:55