Review main Merged

55061[BUGFIX] Change behavior of new element during drag & drop into node

Paweł Rogowicz CR +2 V +2 Normal +109 −51 updated 12/16/17, 13:42

Commit message

- place input correctly
- open node with children while holding the mouse over
this node for one second (when drag-adding new node)
- add chevron and expand it when adding first child
- refactor node.open to node.expand because they did the same thing
- show icons for custom doktypes (fix regex)

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 915

  1. Paweł Rogowicz uploaded patch set 1 12/13/17, 10:39

  2. TYPO3com voted on patch set 1 V +1 12/13/17, 10:48 Completed build in 08m 42s on Wed, 13 Dec, 11:48 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17696

  3. Paweł Rogowicz uploaded patch set 2 12/13/17, 11:54

  4. Paweł Rogowicz uploaded patch set 3 12/13/17, 11:57

  5. Paweł Rogowicz updated the commit message in patch set 4 12/13/17, 11:57

  6. TYPO3com voted on patch set 2 V +1 12/13/17, 12:04 Completed build in 09m 48s on Wed, 13 Dec, 01:04 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17697

  7. TYPO3com voted on patch set 3 V +1 12/13/17, 12:06 Completed build in 08m 58s on Wed, 13 Dec, 01:06 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17698

  8. TYPO3com voted on patch set 4 V +1 12/13/17, 12:07 Completed build in 09m 16s on Wed, 13 Dec, 01:07 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17699

  9. Paweł Rogowicz uploaded patch set 5 12/13/17, 13:28

  10. TYPO3com voted on patch set 5 V +1 12/13/17, 13:36 Completed build in 08m 00s on Wed, 13 Dec, 02:36 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17702

  11. Tymoteusz Motylewski uploaded patch set 6 12/13/17, 14:32

  12. TYPO3com voted on patch set 6 V +1 12/13/17, 14:40 Completed build in 08m 01s on Wed, 13 Dec, 03:40 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17703

  13. Tymoteusz Motylewski voted on patch set 6 V +1 CR +1 12/15/17, 08:27

  14. Andreas Kienast voted on patch set 6 V +2 CR +2 12/16/17, 13:42

  15. Andreas Kienast merged patch set 7 12/16/17, 13:42