Review main Abandoned

55067[WIP] ExtensionConfiguration

Nicole Hummel CR 0 V 0 Normal +155 −57 updated 12/14/17, 11:48

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 10

Review log 45

  1. Nicole Hummel uploaded patch set 1 12/14/17, 11:38

  2. TYPO3com voted on patch set 1 V -1 12/14/17, 11:39 Completed build in 10s on Thu, 14 Dec, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17712

  3. Mathias Brodala commented on patch set 1 12/14/17, 11:41

    ExtensionConfiguration.php:120

    Can't this be reduced to a try...catch with `ArrayUtility::getValueByPath()`? Currently this method is invoked twice for every call, once internally in `ArrayUtility::isValidPath()` and once if that succeeded.
  4. Nicole Hummel commented on patch set 1 12/14/17, 11:48

    ExtensionConfiguration.php:120 Reply

    I know this is done twice but IMHO is the the proper api usage.
  5. Nicole Hummel abandoned the change 12/14/17, 11:48