Review main Merged

55074[TASK] Use hash_equals for timing-safe comparison of hash-values

Stefan Neufeind CR +2 V +2 Easy +13 −13 updated 12/15/17, 15:22

Commit message

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Susi Moog +1
  • Verified V +2
    • Helmut Hummel +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1923

  1. Stefan Neufeind uploaded patch set 1 12/14/17, 13:52

  2. TYPO3com voted on patch set 1 V +1 12/14/17, 14:01 Completed build in 08m 48s on Thu, 14 Dec, 03:01 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17725

  3. Mathias Brodala commented on patch set 1 CR +1 12/14/17, 14:08

    +1 for the changes. I hope you got all of them.
  4. Wolfgang Klinger commented on patch set 1 CR -1 12/14/17, 20:23

    I think the \ in front is unnecessary, no?
  5. Helmut Hummel commented on patch set 1 12/14/17, 20:38

    > I think the \ in front is unnecessary, no? not necessary but still useful because it prevents php to lookup the namespace tree for defined functions
  6. Helmut Hummel voted on patch set 1 V +1 CR +1 12/14/17, 20:38

  7. Wolfgang Klinger voted on patch set 1 CR +1 12/14/17, 20:58

  8. Stefan Neufeind uploaded patch set 2 12/14/17, 21:56

  9. TYPO3com voted on patch set 2 V +1 12/14/17, 22:05 Completed build in 08m 39s on Thu, 14 Dec, 11:05 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17756

  10. Wolfgang Klinger voted on patch set 2 CR +1 12/15/17, 05:55

  11. Oliver Hader voted on patch set 2 CR +1 12/15/17, 09:08

  12. Mathias Brodala voted on patch set 2 CR +1 12/15/17, 09:17

  13. Susi Moog commented on patch set 2 12/15/17, 12:10

    LinkBrowserController.php:123

    the closing brace is wrong here, both params are part of hmac() instead of hash_equals.
  14. Mathias Brodala commented on patch set 3 12/15/17, 12:16

    Published edit on patch set 2.
  15. Mathias Brodala commented on patch set 2 12/15/17, 12:16

    LinkBrowserController.php:123 Reply Unresolved

    Nice catch.
  16. Stephan Großberndt updated the commit message in patch set 4 12/15/17, 12:17

  17. TYPO3com voted on patch set 3 V +1 12/15/17, 12:23 Completed build in 06m 59s on Fri, 15 Dec, 01:23 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17766

  18. TYPO3com voted on patch set 4 V +1 12/15/17, 12:26 Completed build in 09m 06s on Fri, 15 Dec, 01:26 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17767

  19. Susi Moog voted on patch set 4 V +1 CR +1 12/15/17, 12:27

  20. Stephan Großberndt voted on patch set 4 CR -1 12/15/17, 13:05

  21. Stephan Großberndt commented on patch set 4 CR +1 12/15/17, 13:17

    Please note this patch cannot be straight backported to TYPO3_8-7 as at least in \TYPO3\CMS\Backend\Controller\Wizard\ColorpickerController::areFieldChangeFunctionsValid there is another place that needs a hash_equals
  22. Helmut Hummel voted on patch set 4 V +2 CR +2 12/15/17, 15:22

  23. Helmut Hummel merged patch set 5 12/15/17, 15:22