55074[TASK] Use hash_equals for timing-safe comparison of hash-values
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stephan Großberndt +1
- Susi Moog +1
-
Verified V +2
- Helmut Hummel +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php2+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/ImageManipulationWizard.php+1 −1
- typo3/sysext/core/Classes/Controller/FileDumpController.php+1 −1
- typo3/sysext/core/Classes/FormProtection/AbstractFormProtection.php+1 −1
- typo3/sysext/extbase/Classes/Security/Cryptography/HashService.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/Pbkdf2Salt.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/PhpassSalt.php+1 −1
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+2 −2
Review log 1923
-
Stefan Neufeind uploaded patch set 1 12/14/17, 13:52
-
TYPO3com voted on patch set 1 V +1 12/14/17, 14:01 Completed build in 08m 48s on Thu, 14 Dec, 03:01 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17725
-
Mathias Brodala commented on patch set 1 CR +1 12/14/17, 14:08
+1 for the changes. I hope you got all of them. -
Wolfgang Klinger commented on patch set 1 CR -1 12/14/17, 20:23
I think the \ in front is unnecessary, no? -
Helmut Hummel commented on patch set 1 12/14/17, 20:38
> I think the \ in front is unnecessary, no? not necessary but still useful because it prevents php to lookup the namespace tree for defined functions -
Helmut Hummel voted on patch set 1 V +1 CR +1 12/14/17, 20:38
-
Wolfgang Klinger voted on patch set 1 CR +1 12/14/17, 20:58
-
Stefan Neufeind uploaded patch set 2 12/14/17, 21:56
-
TYPO3com voted on patch set 2 V +1 12/14/17, 22:05 Completed build in 08m 39s on Thu, 14 Dec, 11:05 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17756
-
Wolfgang Klinger voted on patch set 2 CR +1 12/15/17, 05:55
-
Oliver Hader voted on patch set 2 CR +1 12/15/17, 09:08
-
Mathias Brodala voted on patch set 2 CR +1 12/15/17, 09:17
-
Susi Moog commented on patch set 2 12/15/17, 12:10
LinkBrowserController.php:123the closing brace is wrong here, both params are part of hmac() instead of hash_equals. -
Mathias Brodala commented on patch set 3 12/15/17, 12:16
Published edit on patch set 2. -
Mathias Brodala commented on patch set 2 12/15/17, 12:16
LinkBrowserController.php:123Reply UnresolvedNice catch. -
Stephan Großberndt updated the commit message in patch set 4 12/15/17, 12:17
-
TYPO3com voted on patch set 3 V +1 12/15/17, 12:23 Completed build in 06m 59s on Fri, 15 Dec, 01:23 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17766
-
TYPO3com voted on patch set 4 V +1 12/15/17, 12:26 Completed build in 09m 06s on Fri, 15 Dec, 01:26 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17767
-
Susi Moog voted on patch set 4 V +1 CR +1 12/15/17, 12:27
-
Stephan Großberndt voted on patch set 4 CR -1 12/15/17, 13:05
-
Stephan Großberndt commented on patch set 4 CR +1 12/15/17, 13:17
Please note this patch cannot be straight backported to TYPO3_8-7 as at least in \TYPO3\CMS\Backend\Controller\Wizard\ColorpickerController::areFieldChangeFunctionsValid there is another place that needs a hash_equals -
Helmut Hummel voted on patch set 4 V +2 CR +2 12/15/17, 15:22
-
Helmut Hummel merged patch set 5 12/15/17, 15:22