Review main Merged

55088[TASK] EXT:scheduler: Last old image and cli_dispatch

Michael Oehlhof CR +2 V +2 Easy +18 −8 updated 12/15/17, 09:08

Commit message

Exchanged the old BackendModuleMainView image and correct the examples
for the command line call.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Benni Mack +1
  • Verified V +2
    • Jigal van Hemert +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Michael Oehlhof uploaded patch set 1 12/14/17, 23:51

  2. Michael Oehlhof commented on patch set 1 CR -1 12/15/17, 00:14

    The command line needs additional changes
  3. TYPO3com voted on patch set 1 V +1 12/15/17, 00:14 Completed build in 23m 20s on Fri, 15 Dec, 01:14 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17757

  4. Michael Oehlhof uploaded patch set 2 12/15/17, 00:27

  5. TYPO3com voted on patch set 2 V -1 12/15/17, 00:50 Completed build in 23m 49s on Fri, 15 Dec, 01:50 AM Test Summary: 1 of 29592 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17758

  6. TYPO3com commented on patch set 2 12/15/17, 01:08 Completed build in 1h 05m 14s on Fri, 15 Dec, 02:08 AM Test Summary: 1 of 30136 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17758

  7. TYPO3com voted on patch set 2 V +1 12/15/17, 01:17 Completed build in 1h 55m 43s on Fri, 15 Dec, 02:17 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17758

  8. Benni Mack commented on patch set 2 12/15/17, 07:26

    hey michael. possible to do this for v8 as well?
  9. Michael Oehlhof commented on patch set 2 12/15/17, 07:40

    @benni: yes that is possible Should we create a new issue for that or use the 72628 for that?
  10. Benni Mack commented on patch set 2 12/15/17, 07:40

    just use the existing ticket.
  11. Benni Mack voted on patch set 2 V +1 CR +1 12/15/17, 07:40

  12. Jigal van Hemert voted on patch set 2 V +2 CR +2 12/15/17, 09:08

  13. Jigal van Hemert merged patch set 3 12/15/17, 09:08