Review main Merged

55091[BUGFIX] Remove deprecated annotation usage in sys_note

Georg Ringer CR -1 V +2 Easy +0 −1 updated 12/18/17, 19:21

Commit message

Review

  • Code review CR -1
    • Benni Mack +2
    • Wouter Wolters +1
    • Alexander Schnitzler +1
    • Jan Helke +1
    • Andreas Kienast -1
  • Verified V +2
    • Benni Mack +2
    • Alexander Schnitzler +1
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 12/15/17, 07:32

  2. TYPO3com voted on patch set 1 V +1 12/15/17, 07:51 Completed build in 19m 20s on Fri, 15 Dec, 08:51 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17761

  3. Jan Helke voted on patch set 1 V +1 CR +1 12/15/17, 10:27

  4. Wouter Wolters voted on patch set 1 CR +1 12/15/17, 10:40

  5. Andreas Kienast commented on patch set 1 CR -1 12/16/17, 13:26

    Hm, shouldn't we use TYPO3\CMS\Extbase\Annotation\IgnoreValidation instead here?
  6. Alexander Schnitzler commented on patch set 1 V +1 CR +1 12/18/17, 10:18

    There is no default validator for strings, so the annotation does not make any sense at all. Therefore it can be removed.
  7. Benni Mack voted on patch set 1 V +2 CR +2 12/18/17, 19:21

  8. Benni Mack merged patch set 2 12/18/17, 19:21