Review main Merged

55097[BUGFIX] AdminPanelView tries to count null value

Oliver Hader CR +2 V +2 Easy +1 −1 updated 12/18/17, 17:38

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Oliver Hader uploaded patch set 1 12/15/17, 15:58

  2. TYPO3com voted on patch set 1 V +1 12/15/17, 16:05 Completed build in 06m 33s on Fri, 15 Dec, 05:05 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17774

  3. Susi Moog voted on patch set 1 V +1 CR +1 12/15/17, 16:05

  4. Nicole Hummel voted on patch set 1 CR +1 12/15/17, 16:13

  5. Susi Moog updated the commit message in patch set 2 12/15/17, 17:55

  6. TYPO3com voted on patch set 2 V +1 12/15/17, 18:05 Completed build in 09m 58s on Fri, 15 Dec, 07:05 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17779

  7. Susi Moog voted on patch set 2 V +1 CR +1 12/15/17, 18:30

  8. Benni Mack voted on patch set 2 V +1 CR +1 12/15/17, 19:28

  9. Susi Moog voted on patch set 2 V +2 CR +2 12/15/17, 19:42

  10. Susi Moog merged patch set 3 12/15/17, 19:42

  11. Susi Moog commented on patch set 3 12/15/17, 19:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0d99482ada4d48ce48199aa40d87076bd21601ae
  12. Alexander Opitz commented on patch set 3 12/18/17, 17:38

    AdminPanelView.php:729

    Hmmm, no is_countable check here as in backport for 7.6?