Review TYPO3_8-7 Merged

55098[TASK] Use hash_equals for timing-safe comparison of hash-values

Stefan Neufeind CR +2 V +2 Easy +14 −14 updated 02/13/18, 07:56

Commit message

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Alexander Opitz +1
    • Stephan Großberndt +1
  • Verified V +2
    • Stefan Neufeind +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1112

  1. Stefan Neufeind uploaded patch set 1 12/15/17, 16:18

  2. Stefan Neufeind commented on patch set 1 12/15/17, 16:24

    Automatic cherry-pick from master applied fine. Then went through to see which additional cases we have in 8.7. Only the ColorpickerController (which didn't exist in master anymore) needed to be added. Please check/verify again.
  3. TYPO3com voted on patch set 1 V +1 12/16/17, 13:56 Completed build in 19h 13m 15s on Sat, 16 Dec, 02:56 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1535

  4. Oliver Klee voted on patch set 1 CR +1 12/16/17, 13:59

  5. Alexander Opitz voted on patch set 1 CR +1 12/18/17, 18:18

  6. Stephan Großberndt voted on patch set 1 CR +1 12/19/17, 11:21

  7. Stefan Neufeind voted on patch set 1 CR +1 12/19/17, 11:35

  8. Stefan Neufeind commented on patch set 1 12/20/17, 00:36

    Can somebody give verified by testing please and have this through? It's in master already and we just needed to add a few additional cases which only appeared in 8.7 it seems. Maybe crosscheck if we found all places - or if we missed some if it maybe applies to master as well.
  9. Alexander Opitz commented on patch set 1 V +1 12/20/17, 08:31

    HashService.php:60

    Hasn't todo with this patch but there is no $hash given.
  10. Mathias Schreiber commented on patch set 1 02/13/18, 07:48

    hi Stefan... wanna merge? :)
  11. Stefan Neufeind commented on patch set 1 V +2 CR +2 02/13/18, 07:56

    Let's have it. Also on a second look this looks fine to me.
  12. Stefan Neufeind merged patch set 2 02/13/18, 07:56