Review main Abandoned

55103[WIP][BUGFIX] Add missing htmlspecialchars() calls

Stephan Großberndt CR 0 V 0 Easy +10 −10 updated 09/30/18, 16:35

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 2433

Show 48 earlier messages
  1. Stephan Großberndt uploaded patch set 1 12/15/17, 21:23

  2. TYPO3com voted on patch set 1 V +1 12/15/17, 21:29 Completed build in 06m 47s on Fri, 15 Dec, 10:29 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17787

  3. Stephan Großberndt uploaded patch set 2 12/15/17, 22:04

  4. TYPO3com voted on patch set 2 V +1 12/15/17, 22:11 Completed build in 06m 53s on Fri, 15 Dec, 11:11 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17788

  5. Stephan Großberndt uploaded patch set 3 12/15/17, 22:40

  6. TYPO3com voted on patch set 3 V -1 12/15/17, 22:40 Completed build in 08s on Fri, 15 Dec, 11:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17789

  7. Stefan Neufeind uploaded patch set 4 12/15/17, 23:31

  8. TYPO3com voted on patch set 4 V +1 12/15/17, 23:38 Completed build in 06m 24s on Sat, 16 Dec, 12:38 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17790

  1. Stefan Neufeind uploaded patch set 5 12/16/17, 02:10

  2. TYPO3com voted on patch set 5 V -1 12/16/17, 02:10 Completed build in 09s on Sat, 16 Dec, 03:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17791

  3. Stefan Neufeind uploaded patch set 6 12/16/17, 02:17

  4. TYPO3com voted on patch set 6 V +1 12/16/17, 02:24 Completed build in 07m 18s on Sat, 16 Dec, 03:24 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17792

  5. Oliver Klee commented on patch set 6 CR -1 12/16/17, 09:42

    This change request mixes different kinds of (very good) clean-up, security fixes and polish. I find this hard to review. I propose splitting this up into several separate change requests where each CR covers a distinct type of change (e.g., one for the HSC changes, another for variable name cleanup etc.)
  6. Stephan Großberndt commented on patch set 6 12/16/17, 09:45

    Stefan and me agreed on that already on the way home yesterday. I should have marked it as WIP beforehand, sorry.
  7. Oliver Klee updated the commit message in patch set 7 12/16/17, 09:53

  8. TYPO3com voted on patch set 7 V +1 12/16/17, 10:00 Completed build in 06m 43s on Sat, 16 Dec, 11:00 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17793

  9. Stephan Großberndt uploaded patch set 8 12/16/17, 10:57

  10. Stephan Großberndt commented on patch set 8 12/16/17, 10:58

    Moved preview box changes to https://review.typo3.org/#/c/55108/ and enhanced them
  11. TYPO3com voted on patch set 8 V +1 12/16/17, 11:04 Completed build in 07m 01s on Sat, 16 Dec, 12:04 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17799

  12. Stephan Großberndt commented on patch set 8 12/16/17, 11:10

    locallang_reports.xlf:58

    Why is this changed / added?
  13. Stephan Großberndt commented on patch set 8 12/16/17, 11:25

    DebuggerUtility.php:275

    Why always add the span if it has no content?
  14. Stephan Großberndt commented on patch set 8 12/16/17, 12:42

    core/Classes/Database/QueryView.php in https://review.typo3.org/#/c/55111/
  15. Stephan Großberndt commented on patch set 8 12/16/17, 12:58

  16. Stephan Großberndt commented on patch set 8 12/16/17, 13:03

  17. Stephan Großberndt commented on patch set 8 12/16/17, 13:11

  18. Stephan Großberndt commented on patch set 8 12/16/17, 13:20

    SystemStatusUpdateTask.php:108

    Stefan, can you please explain this change?
  19. Stephan Großberndt uploaded patch set 9 12/16/17, 13:23

  20. Stephan Großberndt commented on patch set 9 CR -1 12/16/17, 13:25

    Stefan, please review and explain.

    SystemStatusUpdateTask.php:108

    ?

    locallang_reports.xlf:58

    ?
  21. TYPO3com voted on patch set 9 V +1 12/16/17, 13:33 Completed build in 09m 26s on Sat, 16 Dec, 02:33 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17811

  22. Stephan Großberndt commented on patch set 9 12/16/17, 17:29

    SystemStatusUpdateTask.php:108 Reply

    https://review.typo3.org/#/c/50811/ intentionally removed those links, why do you want to bring them back?
  23. Christian Kuhn abandoned the change 09/16/18, 23:58

    hey. this patch stalled in the review system for more than a year. i'll abandon it for now since it has merge conflicts, too and nobody is working on it. please feel free to rebase an push again if you continue to work on it.
  24. Stephan Großberndt restored the change 09/30/18, 16:35

  25. Stephan Großberndt abandoned the change 09/30/18, 16:35