55108[TASK] Localize preview boxes
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 4457
Show 2632 earlier messages
-
Stephan Großberndt uploaded patch set 1 12/16/17, 10:45
-
TYPO3com voted on patch set 1 V +1 12/16/17, 10:52 Completed build in 06m 46s on Sat, 16 Dec, 11:52 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17798
-
Stephan Großberndt updated the commit message in patch set 2 12/16/17, 11:06
-
Oliver Klee commented on patch set 2 12/16/17, 11:10
-
TYPO3com voted on patch set 2 V +1 12/16/17, 11:13 Completed build in 06m 59s on Sat, 16 Dec, 12:13 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17800
-
Stephan Großberndt uploaded patch set 3 12/16/17, 11:22
-
TYPO3com voted on patch set 3 V +1 12/16/17, 11:29 Completed build in 07m 25s on Sat, 16 Dec, 12:29 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17801
-
Stefan Neufeind commented on patch set 3 V +1 CR +1 12/16/17, 19:00
FrontendHooks.php:58personal taste: I'd maybe move the htmlspecialchars() down here, right where it is finally output/embedded into HTML-code same in the other file -
Stephan Großberndt commented on patch set 4 12/16/17, 20:07
Published edit on patch set 3. -
Stephan Großberndt commented on patch set 5 12/16/17, 20:07
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 12/16/17, 20:14 Completed build in 06m 54s on Sat, 16 Dec, 09:14 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17833
-
TYPO3com voted on patch set 4 V +1 12/16/17, 20:15 Completed build in 07m 56s on Sat, 16 Dec, 09:15 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17832
-
Tymoteusz Motylewski commented on patch set 5 12/18/17, 13:22
Any idea when the text and link to stop preview were hidden? was that a regression or a conscious decision? -
Georg Ringer commented on patch set 5 12/18/17, 13:51
do we really need a dependency to extbase for that? -
Stephan Großberndt commented on patch set 5 V -1 CR -1 12/18/17, 14:35
@tymotyl: According to https://review.typo3.org/#/c/53558/2/typo3/sysext/workspaces/Classes/Hook/TypoScriptFrontendControllerHook.php this was by mistake which will be fixed by Benji, I invited him to review this patch - which now obviously need a new patchset with a re-added $text and a styled preview-link. @georg Thats right. What should we use instead? Searching for 'use TYPO3\CMS\Extbase\Utility\LocalizationUtility;' in the core lists many other core extensions using it - including \TYPO3\CMS\Workspaces\Controller\Remote\RemoteServer. If this should be changed - then in another patch? -
Stephan Großberndt uploaded patch set 6 12/18/17, 17:03
-
TYPO3com voted on patch set 6 V +1 12/18/17, 17:10 Completed build in 07m 10s on Mon, 18 Dec, 06:10 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17859
-
Stefan Neufeind commented on patch set 6 CR +1 12/19/17, 06:58
i'm with Stephan to Look separately about how to replace the extbase-localisation-utility -
Benjamin Kluge voted on patch set 6 CR +1 12/19/17, 13:13
-
Stephan Großberndt commented on patch set 6 12/19/17, 13:37
This patch needs approval by Benjamin Kott for the "stop preview"-Link in workspaces -
Georg Ringer voted on patch set 6 V +1 CR +1 12/21/17, 08:47
-
Stefan Neufeind commented on patch set 6 12/21/17, 09:12
Replacing LocalizationUtility definitely in a separate patch, in other places as well. I've looked into making that beast Extbase-free - maybe let's talk about it with some interested folks ... -
Benjamin Kott commented on patch set 6 CR -1 12/22/17, 07:32
FrontendHooks.php:51Why did you add uppercase again? I just removed it ;)TypoScriptFrontendControllerHook.php:93Why did you add uppercase again? I just removed it ;) -
Benjamin Kott commented on patch set 6 12/22/17, 07:44
FrontendHooks.php:17Why not using the \TYPO3\CMS\Core\Localization\LanguageService?TypoScriptFrontendControllerHook.php:19Why not using the \TYPO3\CMS\Core\Localization\LanguageService? -
Benjamin Kott commented on patch set 6 12/22/17, 08:13
We need to backport this patch to 8.7 for making the stop preview link available again, even i have not figured out yet how to display it besides changing the code.TypoScriptFrontendControllerHook.php:81Sadly this was missing, in master when i did changes to the styling. We need to rework the complete workspace header in later versions, for now i would suggest we just set pointer-events to auto for this link. This will make it clickable again and should be fine for now until we have a better solution in pleace. -
Stefan Neufeind commented on patch set 6 12/22/17, 08:47
FrontendHooks.php:17ReplyBy definition (for the moment) LanguageService is for backend-usage only. We've discussed a solution in the last days, but imho that would be a larger separate change. For now LocalizationUtility would be right imho. -
Stephan Großberndt commented on patch set 6 CR -1 12/22/17, 10:05
FrontendHooks.php:17ReplyI used the same class the other hook uses.FrontendHooks.php:51ReplyWill remove.TypoScriptFrontendControllerHook.php:19ReplyThis class did already use TYPO3\CMS\Extbase\Utility\LocalizationUtility before.TypoScriptFrontendControllerHook.php:93ReplyI was not sure this was intended, will remove it again :-) -
Stefan Neufeind commented on patch set 6 CR -1 12/22/17, 10:21
FrontendHooks.php:17ReplyAfter talking to Benni a minute ago: Yes, LanguageService is the right solution here. It can work in the frontend already, but will rely on the currently loggedin backend-user - which is the right solution for our preview-case. The page itself can show in whatever language is selected for the frontend (LocalizationUtilty) but the preview-buttons etc. here would show based on the backend-user-settings (LanguageService). We agreed to look further into the Language/Localization-topic separately and discussed some things already. Let's talk about that separately when interested. -
Stephan Großberndt commented on patch set 6 12/22/17, 10:22
Ok, currently working on the patch, will switch both files to LanguageService -
Stephan Großberndt commented on patch set 6 12/22/17, 11:04
TypoScriptFrontendControllerHook.php:73Here we have a drawback if switching to languageService as that class only has getLL($label) which does not have the functionality to replace arguments in the label -
Stefan Neufeind commented on patch set 6 12/22/17, 11:10
TypoScriptFrontendControllerHook.php:73Replythat's just a vsprintf-call, right? We could do that directly here or with a helper-function. But calling vsprintf directly should be doable? -
Stephan Großberndt commented on patch set 6 12/22/17, 11:13
TypoScriptFrontendControllerHook.php:73ReplyI went for sprintf like in line 67 now. We just have to keep that in mind for switching LocalizationUtility to LanguageService
-
Stephan Großberndt uploaded patch set 7 12/22/17, 11:18
-
TYPO3com voted on patch set 7 V -1 12/22/17, 11:18 Completed build in 08s on Fri, 22 Dec, 12:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17935
-
Stephan Großberndt uploaded patch set 8 12/22/17, 11:20
-
TYPO3com voted on patch set 8 V -1 12/22/17, 11:27 Completed build in 06m 30s on Fri, 22 Dec, 12:27 PM Test Summary: 373 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17936
-
Stephan Großberndt commented on patch set 8 12/22/17, 13:01
I could use some help on finding out why the functionals fail. I tested this on a 8.7 instance (due to PHP restrictions no master available here) and no errors ocurred.TypoScriptFrontendControllerHook.php:78What do I have to set in TYPO3 so the "stop preview" link is actually rendered? With the current preview as implemented in TYPO3 8.7 and up the "stop preview" link does not make any sense to me. What do you think? Remove it? Clicking on it displays unformatted "You logged out from Workspace preview mode. Click this link to go back to the website" and when you click you're back in the preview -
Benjamin Kott commented on patch set 8 CR -1 12/22/17, 15:42
TypoScriptFrontendControllerHook.php:81add pointer-events: none hereTypoScriptFrontendControllerHook.php:96pointer events must be none here at this element! -
Benjamin Kott commented on patch set 8 12/22/17, 15:42
TypoScriptFrontendControllerHook.php:81Replyi mean "pointer-events: auto" -
Stephan Großberndt uploaded patch set 9 12/22/17, 16:32
-
Stephan Großberndt commented on patch set 9 12/22/17, 16:33
With the current preview as implemented in TYPO3 8.7 and up the "stop preview" link does not make any sense to me. What do you think? Remove it? Clicking on it displays unformatted "You logged out from Workspace preview mode. Click this link to go back to the website" and when you click you're back in the preview... -
TYPO3com voted on patch set 9 V -1 12/22/17, 16:43 Completed build in 10m 37s on Fri, 22 Dec, 05:43 PM Test Summary: 373 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17947
-
Mathias Schreiber updated the commit message in patch set 10 02/05/18, 21:30
-
TYPO3com voted on patch set 10 V -1 02/05/18, 21:39 Completed build in 09m 33s on Mon, 5 Feb, 10:39 PM Test Summary: 373 of 30571 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18984
-
Stephan Großberndt commented on patch set 10 02/06/18, 10:34
Georg, now you see why we need the dependency to TYPO3\CMS\Extbase\Utility\LocalizationUtility was the better choice. In the frontend $GLOBALS['LANG'] -
Stephan Großberndt commented on patch set 10 02/06/18, 10:35
In the tests $GLOBALS['LANG'] is apparently not available. So how to proceed here? Back to TYPO3\CMS\Extbase\Utility\LocalizationUtility or have $GLOBALS['LANG'] in the tests somehow? -
Andreas Kienast commented on patch set 10 02/06/18, 13:22
It looks like only ActionTest is affected, I think it's better to instantiate LanguageService in there. -
Benni Mack commented on patch set 10 03/04/18, 12:23
please rebase, should be doable with LanguageService now (also in the workspaces part, which is now a middleware) -
Mathias Schreiber uploaded patch set 11 03/04/18, 13:39
-
TYPO3com voted on patch set 11 V +1 03/04/18, 13:49 Completed build in 09m 30s on Sun, 4 Mar, 02:49 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20482
-
Benni Mack uploaded patch set 12 03/04/18, 20:37
-
Benni Mack commented on patch set 13 03/04/18, 20:37
Published edit on patch set 12. -
TYPO3com voted on patch set 12 V +1 03/04/18, 20:46 Completed build in 09m 13s on Sun, 4 Mar, 09:46 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20507
-
TYPO3com voted on patch set 13 V +1 03/04/18, 20:48 Completed build in 10m 41s on Sun, 4 Mar, 09:48 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20508
-
Mathias Schreiber voted on patch set 13 V +1 CR +1 03/04/18, 20:52
-
Benni Mack voted on patch set 13 V +2 CR +2 03/05/18, 06:43
-
Benni Mack merged patch set 14 03/05/18, 06:43
FrontendHooks.php:40