Review main Merged

5511[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts

Stanislas Rolland CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Problem: Fixed JS scripts may not be loaded when a new version of
TYPO3 is released. This may happen if the version of htmlArea RTE was
not incremented. This is an error-prone situation.
Solution: Add TYPO3 version to hash of cached scripts

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 1

Review log 6

  1. Stanislas Rolland uploaded patch set 2 10/04/11, 03:57

  2. Stanislas Rolland commented on patch set 2 V 0 10/04/11, 03:57

    by team member; Looks good to me, approved
  3. Georg Ringer commented on patch set 1 V 0 10/04/11, 03:57

    by team member; Looks good to me, approved please submit but wouldn't this be a good change for the core in general?

    class.tx_rtehtmlarea_base.php:1149

    this should be t3lib_div::getUrl() IMO but not part of zthe patch
  4. Mr. Jenkins commented on patch set 1 10/04/11, 03:57

  5. Mr. Jenkins commented on patch set 2 10/04/11, 03:57

  6. Stanislas Rolland merged patch set 2 10/04/11, 03:57