Review main Merged

55111[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView

Stephan Großberndt CR +2 V +2 Normal +63 −85 updated 02/13/18, 14:19

Commit message

Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Jörg Bösche +1
  • Verified V +2
    • Frank Nägler +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 3344

Show 1219 earlier messages
  1. Stephan Großberndt uploaded patch set 1 12/16/17, 12:41

  2. TYPO3com voted on patch set 1 V +1 12/16/17, 12:47 Completed build in 05m 46s on Sat, 16 Dec, 01:47 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17802

  3. Stephan Großberndt updated the commit message in patch set 2 12/16/17, 13:31

  4. TYPO3com voted on patch set 2 V +1 12/16/17, 13:40 Completed build in 08m 47s on Sat, 16 Dec, 02:40 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17813

  5. Andreas Kienast voted on patch set 2 CR +1 12/16/17, 13:51

  6. Stephan Großberndt updated the commit message in patch set 3 12/16/17, 15:11

  7. TYPO3com voted on patch set 3 V +1 12/16/17, 15:22 Completed build in 11m 12s on Sat, 16 Dec, 04:22 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17826

  8. Reiner Teubner uploaded patch set 4 02/06/18, 11:39

  9. TYPO3com voted on patch set 4 V +1 02/06/18, 11:47 Completed build in 08m 35s on Tue, 6 Feb, 12:47 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19008

  10. Jörg Bösche commented on patch set 4 V -1 CR -1 02/06/18, 14:50

    QueryView.php:520

    Should be $out === ''. Display the error message, if the output is empty.

    QueryView.php:527

    Missing $out .= General.... here?
  11. Tobi Kretschmann commented on patch set 4 V -1 CR -1 02/06/18, 14:50

    QueryView.php:527

    This FlashMessage is never shown. It needs to be concatenated to the output string. $out .= GeneralUtility::makeInstance(FlashMessageRendererResolver::class)
  12. Tobi Kretschmann commented on patch set 4 02/06/18, 14:51

    i am on it
  13. Tobi Kretschmann uploaded patch set 5 02/06/18, 14:52

  14. TYPO3com voted on patch set 5 V +1 02/06/18, 14:58 Completed build in 06m 15s on Tue, 6 Feb, 03:58 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19018

  15. Tobi Kretschmann uploaded patch set 6 02/06/18, 15:02

  16. Jörg Bösche commented on patch set 6 CR -1 02/06/18, 15:04

    QueryView.php:1248

    Use inline return statement.
  17. Tobi Kretschmann uploaded patch set 7 02/06/18, 15:06

  18. TYPO3com voted on patch set 6 V +1 02/06/18, 15:10 Completed build in 07m 00s on Tue, 6 Feb, 04:10 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19020

  19. TYPO3com voted on patch set 7 V +1 02/06/18, 15:12 Completed build in 05m 58s on Tue, 6 Feb, 04:12 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19021

  1. Jörg Bösche voted on patch set 7 V +1 CR +1 02/06/18, 15:12

  2. Benni Mack commented on patch set 7 02/10/18, 23:06

    QueryView.php:713

    I don't think we need to quote twice here... How about we split the patch in multiple parts (so it's easier to backport as well)
  3. Mathias Schreiber uploaded patch set 8 02/12/18, 19:59

  4. TYPO3com voted on patch set 8 V +1 02/12/18, 20:07 Completed build in 08m 33s on Mon, 12 Feb, 09:07 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19402

  5. Mathias Schreiber voted on patch set 8 V +1 CR +1 02/13/18, 09:38

  6. Oliver Klee commented on patch set 7 02/13/18, 11:14

    QueryView.php:713 Reply

    +1
  7. Stefan Neufeind commented on patch set 7 02/13/18, 11:18

    QueryView.php:713 Reply

    Don't we usually quote like this in other places? Once because it's in a JS-block (quoteJSvalue) and then because it's used inside html (onClick).
  8. Frank Nägler commented on patch set 8 CR -1 02/13/18, 11:53

    on it
  9. Frank Nägler uploaded patch set 9 02/13/18, 12:12

  10. TYPO3com voted on patch set 9 V -1 02/13/18, 12:12 Completed build in 10s on Tue, 13 Feb, 01:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19484

  11. Frank Nägler commented on patch set 9 V +1 CR +1 02/13/18, 12:14

    My changes in this patchset: - render flashMessage only on top of the page and removed the direkt FlashMessage rendering - fixed a broken result for count function
  12. Frank Nägler uploaded patch set 10 02/13/18, 12:15

  13. Frank Nägler voted on patch set 10 V +1 CR +1 02/13/18, 12:15

  14. TYPO3com voted on patch set 10 V +1 02/13/18, 12:25 Completed build in 10m 36s on Tue, 13 Feb, 01:25 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19486

  15. Sascha Rademacher voted on patch set 10 CR +1 02/13/18, 12:31

  16. Mathias Schreiber voted on patch set 10 V +1 CR +1 02/13/18, 12:33

  17. Tobi Kretschmann commented on patch set 10 02/13/18, 12:39

    I know it's a bit picky, but now the FlashMessage "No row selected" is shown at first. But at the end the headline "Result" is still visible.
  18. Tobi Kretschmann uploaded patch set 11 02/13/18, 12:49

  19. TYPO3com voted on patch set 11 V +1 02/13/18, 12:57 Completed build in 07m 46s on Tue, 13 Feb, 01:57 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19489

  20. Tobi Kretschmann voted on patch set 11 V +1 CR +1 02/13/18, 13:01

  21. Sascha Rademacher voted on patch set 11 V +1 CR +1 02/13/18, 13:03

  22. Jörg Bösche voted on patch set 11 V +1 CR +1 02/13/18, 13:09

  23. Stefan Neufeind voted on patch set 11 CR +1 02/13/18, 13:13

  24. Frank Nägler voted on patch set 11 V +2 CR +2 02/13/18, 14:19

  25. Frank Nägler merged patch set 12 02/13/18, 14:19