Review main Merged

55112[TASK] Raise ext:styleguide extension versions

Oliver Hader CR +2 V +2 Easy +8 −8 updated 12/16/17, 13:21

Commit message

Raise ext:styleguide extension versions to
* 9.0.1
* 8.0.14

The styleguide extensions uses and invalid configuration for FAL
references using the table sys_file_reference as MM table - the
regular use case is to use that as 1:n foreign_field composite
assiciation. In a result the example in the styleguide extension
mixed the meaning and behavior of both fields uid_local and
uid_foreign.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 58

  1. Oliver Hader uploaded patch set 1 12/16/17, 12:46

  2. TYPO3com voted on patch set 1 V +1 12/16/17, 12:53 Completed build in 06m 41s on Sat, 16 Dec, 01:53 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17803

  3. Oliver Hader updated the commit message in patch set 2 12/16/17, 12:54

  4. Oliver Hader updated the commit message in patch set 3 12/16/17, 12:57

  5. TYPO3com voted on patch set 2 V +1 12/16/17, 13:03 Completed build in 08m 13s on Sat, 16 Dec, 02:03 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17804

  6. TYPO3com voted on patch set 3 V +1 12/16/17, 13:13 Completed build in 16m 53s on Sat, 16 Dec, 02:13 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17806

  7. Susi Moog voted on patch set 3 V +2 CR +2 12/16/17, 13:21

  8. Susi Moog merged patch set 4 12/16/17, 13:21