Review TYPO3_8-7 Merged

55114[TASK] Raise ext:styleguide extension versions

Oliver Hader CR +2 V +2 Easy +7 −7 updated 12/16/17, 13:21

Commit message

Raise ext:styleguide extension versions to
* 9.0.1
* 8.0.14

The styleguide extensions uses and invalid configuration for FAL
references using the table sys_file_reference as MM table - the
regular use case is to use that as 1:n foreign_field composite
assiciation. In a result the example in the styleguide extension
mixed the meaning and behavior of both fields uid_local and
uid_foreign.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Oliver Hader uploaded patch set 1 12/16/17, 12:56

  2. Oliver Hader updated the commit message in patch set 2 12/16/17, 12:56

  3. TYPO3com voted on patch set 1 V +1 12/16/17, 13:13 Completed build in 17m 00s on Sat, 16 Dec, 02:13 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1541

  4. TYPO3com voted on patch set 2 V +1 12/16/17, 13:19 Completed build in 22m 26s on Sat, 16 Dec, 02:19 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1542

  5. Oliver Hader voted on patch set 2 V +2 CR +2 12/16/17, 13:21

  6. Oliver Hader merged patch set 3 12/16/17, 13:21