55115[BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Anja Leichsenring +1
- Jörg Bösche +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1314
-
Stephan Großberndt uploaded patch set 1 12/16/17, 12:56
-
TYPO3com voted on patch set 1 V +1 12/16/17, 13:11 Completed build in 14m 15s on Sat, 16 Dec, 02:11 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17805
-
Jörg Bösche voted on patch set 1 CR +1 12/16/17, 23:36
-
Stefan Neufeind voted on patch set 1 V +1 CR +1 12/17/17, 02:28
-
Oliver Klee commented on patch set 1 12/17/17, 14:14
-
Stephan Großberndt commented on patch set 1 12/17/17, 14:36
DebuggerUtility.php:470ReplyThats correct - but this is not necessary for html rendering (non-plaintext) as here the empty spaces are not rendered (like lines 444-448) -
Oliver Klee commented on patch set 1 12/17/17, 23:24
DebuggerUtility.php:470ReplyThen please let's keep this separate. Having only the HSC changes in this changeset (and no other structural changes) makes this change request a lot easier to review. -
Stephan Großberndt commented on patch set 1 12/18/17, 00:09
DebuggerUtility.php:470ReplyThere is only one other line changed in the same class in this patch. Here htmlspecialchars is added too. I am not going to prepare a separate patch for this - if you want to do that, go ahead. -
Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 08:09
-
Benni Mack voted on patch set 1 V +2 CR +2 12/27/17, 09:39
-
Benni Mack merged patch set 2 12/27/17, 09:39
-
Benjamin Kott commented on patch set 2 12/29/17, 11:58
post -1 debugger output is now inlined, tree structure is gone. -
Oliver Klee commented on patch set 2 12/29/17, 12:40
That's why I prefer to keep different kinds of changes to different change sets (in this case: structural changes and cleanup separate from adding HSC). -
Stephan Großberndt commented on patch set 2 01/02/18, 13:51
Followup https://review.typo3.org/#/c/55242/
DebuggerUtility.php:470