Review main Merged

55115[BUGFIX] Add missing htmlspecialchars() and cleanup in DebuggerUtility

Stephan Großberndt CR +2 V +2 Easy +7 −2 updated 01/02/18, 13:51

Commit message

Add missing htmlspecialchars() calls in
EXT:extbase/Classes/Utility/DebuggerUtility.php and cleanup indents in
collections.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1314

  1. Stephan Großberndt uploaded patch set 1 12/16/17, 12:56

  2. TYPO3com voted on patch set 1 V +1 12/16/17, 13:11 Completed build in 14m 15s on Sat, 16 Dec, 02:11 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17805

  3. Jörg Bösche voted on patch set 1 CR +1 12/16/17, 23:36

  4. Stefan Neufeind voted on patch set 1 V +1 CR +1 12/17/17, 02:28

  5. Oliver Klee commented on patch set 1 12/17/17, 14:14

    DebuggerUtility.php:470

    This now changes the functionality: The PHP_EOL indent stuff is missing in the else case (unless I'm reading this wrong).
  6. Stephan Großberndt commented on patch set 1 12/17/17, 14:36

    DebuggerUtility.php:470 Reply

    Thats correct - but this is not necessary for html rendering (non-plaintext) as here the empty spaces are not rendered (like lines 444-448)
  7. Oliver Klee commented on patch set 1 12/17/17, 23:24

    DebuggerUtility.php:470 Reply

    Then please let's keep this separate. Having only the HSC changes in this changeset (and no other structural changes) makes this change request a lot easier to review.
  8. Stephan Großberndt commented on patch set 1 12/18/17, 00:09

    DebuggerUtility.php:470 Reply

    There is only one other line changed in the same class in this patch. Here htmlspecialchars is added too. I am not going to prepare a separate patch for this - if you want to do that, go ahead.
  9. Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 08:09

  10. Benni Mack voted on patch set 1 V +2 CR +2 12/27/17, 09:39

  11. Benni Mack merged patch set 2 12/27/17, 09:39

  12. Benjamin Kott commented on patch set 2 12/29/17, 11:58

    post -1 debugger output is now inlined, tree structure is gone.
  13. Oliver Klee commented on patch set 2 12/29/17, 12:40

    That's why I prefer to keep different kinds of changes to different change sets (in this case: structural changes and cleanup separate from adding HSC).
  14. Stephan Großberndt commented on patch set 2 01/02/18, 13:51