Review main Merged

55116[BUGFIX] Fix quoting and cleanup in AdminPanelView

Stephan Großberndt CR +2 V +2 Normal +44 −37 updated 02/11/18, 00:02

Commit message

In EXT:frontend/Classes/View/AdminPanelView.php add missing
htmlspecialchars() calls, remove unnecessary ones, add quoteJSvalues()
and do cleanup.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1320

  1. Stephan Großberndt uploaded patch set 1 12/16/17, 13:03

  2. TYPO3com voted on patch set 1 V +1 12/16/17, 13:14 Completed build in 11m 10s on Sat, 16 Dec, 02:14 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17807

  3. Michael Oehlhof commented on patch set 1 12/17/17, 00:28

    AdminPanelView.php:440

    Why is htmlspecialchars() called for a static string without html special chars inside?
  4. Stephan Großberndt commented on patch set 1 12/17/17, 08:42

    AdminPanelView.php:440 Reply

    It is not necessary, thats why they are removed.this was part of a bigger patch. I am going to adapt the commit message.
  5. Stephan Großberndt updated the commit message in patch set 2 12/17/17, 09:53

  6. TYPO3com voted on patch set 2 V +1 12/17/17, 10:02 Completed build in 08m 28s on Sun, 17 Dec, 11:02 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17836

  7. Stefan Neufeind commented on patch set 2 12/17/17, 13:32

    AdminPanelView.php:466

    similar some lines below but there it's with doublequotes. decide how we want it and clean it up
  8. Stephan Großberndt commented on patch set 2 12/17/17, 14:30

    AdminPanelView.php:468

    If you are talking about here: htmlspecialchars()?
  9. Mathias Schreiber uploaded patch set 3 02/10/18, 22:04

  10. TYPO3com voted on patch set 3 V -1 02/10/18, 22:13 Completed build in 08m 49s on Sat, 10 Feb, 11:13 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19314

  11. TYPO3com voted on patch set 3 V +1 02/10/18, 22:17 Completed build in 21m 32s on Sat, 10 Feb, 11:17 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19314

  12. Benni Mack commented on patch set 3 02/10/18, 22:50

    AdminPanelView.php:748

    this should be htmlspecialchars() - right?
  13. Mathias Schreiber uploaded patch set 4 02/10/18, 22:59

  14. TYPO3com voted on patch set 4 V -1 02/10/18, 23:08 Completed build in 08m 34s on Sun, 11 Feb, 12:08 AM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19322

  15. TYPO3com commented on patch set 4 02/10/18, 23:20 Completed build in 29m 25s on Sun, 11 Feb, 12:20 AM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19322

  16. TYPO3com voted on patch set 4 V +1 02/10/18, 23:33 Completed build in 1h 02m 45s on Sun, 11 Feb, 12:33 AM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19322

  17. Mathias Schreiber voted on patch set 4 V +1 CR +1 02/10/18, 23:37

  18. Benni Mack voted on patch set 4 V +2 CR +2 02/11/18, 00:01

  19. Benni Mack merged patch set 5 02/11/18, 00:01

  20. Benni Mack commented on patch set 5 02/11/18, 00:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b48c2a201cf387eb72e950d1ab9767de05cf140d