Review main Merged

55119[BUGFIX] Add missing htmlspecialchars() in ActionTask

Stephan Großberndt CR +2 V +2 Easy +25 −24 updated 01/05/18, 12:32

Commit message

Add missing htmlspecialchars() calls in
EXT:sys_action/Classes/ActionTask.php

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Steffen Kamper +1
    • Jörg Bösche +1
    • Michael Oehlhof +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Stephan Großberndt uploaded patch set 1 12/16/17, 13:20

  2. TYPO3com voted on patch set 1 V +1 12/16/17, 13:27 Completed build in 07m 26s on Sat, 16 Dec, 02:27 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17809

  3. Anja Leichsenring commented on patch set 1 12/20/17, 16:55

    ActionTask.php:242 Unresolved

    use $title here as well?

    ActionTask.php:300 Unresolved

    use a variable for the title here as well? use it then in both occurrences.
  4. Stephan Großberndt uploaded patch set 2 12/21/17, 14:49

  5. TYPO3com voted on patch set 2 V +1 12/21/17, 14:57 Completed build in 07m 22s on Thu, 21 Dec, 03:57 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17931

  6. Jörg Bösche voted on patch set 2 CR +1 12/22/17, 07:32

  7. Michael Oehlhof voted on patch set 2 CR +1 12/22/17, 11:55

  8. Stefan Neufeind voted on patch set 2 CR +1 12/22/17, 11:58

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/27/17, 07:45

  10. Steffen Kamper voted on patch set 2 CR +1 01/05/18, 10:14

  11. Oliver Klee voted on patch set 2 CR +1 01/05/18, 11:58

  12. Stefan Neufeind voted on patch set 2 V +2 CR +2 01/05/18, 12:32

  13. Stefan Neufeind merged patch set 3 01/05/18, 12:32