Review main Merged

55136[BUGFIX] Correct permissions for root page setting up empty site

Stephan Großberndt CR +2 V +2 Easy +2 −2 updated 01/02/18, 18:25

Commit message

Use the correct maximal permission "31" for the root page when setting
up an empty site during the installation process instead of "32" which
leads to non-editable permissions for that page even by an admin.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Reiner Teubner +1
    • Oliver Hader +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • Reiner Teubner +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Stephan Großberndt uploaded patch set 1 12/17/17, 13:14

  2. TYPO3com voted on patch set 1 V +1 12/17/17, 13:21 Completed build in 06m 57s on Sun, 17 Dec, 02:21 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17837

  3. Wouter Wolters voted on patch set 1 CR +1 12/17/17, 13:23

  4. Oliver Hader voted on patch set 1 CR +1 12/17/17, 13:36

  5. Oliver Hader commented on patch set 1 12/17/17, 13:37

    FYI: In 7.6 that's in typo3/sysext/install/Classes/Controller/Action/Step/DefaultConfiguration.php - for backporting
  6. Oliver Klee voted on patch set 1 CR +1 12/17/17, 14:12

  7. Benni Mack voted on patch set 1 V +1 CR +2 12/27/17, 15:03

  8. Reiner Teubner voted on patch set 1 V +1 CR +1 01/02/18, 16:15

  9. Anja Leichsenring voted on patch set 1 V +1 CR +1 01/02/18, 16:21

  10. Stefan Neufeind voted on patch set 1 V +2 CR +2 01/02/18, 18:25

  11. Stefan Neufeind merged patch set 2 01/02/18, 18:25