Review main Abandoned

5514[BUGFIX] Email links marked as external when preceded by external link

Stanislas Rolland CR 0 V 0 Easy +3 −1 updated 06/03/13, 20:49

Commit message

Some variables are not initialized leading to incorrect transformation
on both way: to database and to RTE.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 9

  1. Stanislas Rolland uploaded patch set 2 10/04/11, 16:07

  2. Stanislas Rolland uploaded patch set 3 10/04/11, 16:07

  3. Stanislas Rolland commented on patch set 3 10/04/11, 16:07

    Sorry, I have mishandled my local git repository. I will need to resubmit these changes. But yes, your comment is correct.
  4. Markus Klein commented on patch set 2 10/04/11, 16:07

    (2 inline comments)

    class.t3lib_parsehtml_proc.php:561

    Useless, since you initialize it anyway 2 lines below

    class.t3lib_parsehtml_proc.php:562

    Initialized below too: $attribArray_copy = $attribArray;
  5. Markus Klein commented on patch set 3 10/04/11, 16:07

    What's the difference to Patch Set 2?? Did you see my comments on Set 2?
  6. Mr. Jenkins commented on patch set 1 10/04/11, 16:07

  7. Mr. Jenkins commented on patch set 2 10/04/11, 16:07

  8. Mr. Jenkins commented on patch set 3 10/04/11, 16:07

  9. Stanislas Rolland commented on patch set 3 10/04/11, 16:07

    Abandoned Need to resubmit.