55142[BUGFIX] Updated class name in scheduler docs
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1520
-
Michael Oehlhof uploaded patch set 1 12/17/17, 23:39
-
TYPO3com voted on patch set 1 V -1 12/17/17, 23:39 Completed build in 08s on Mon, 18 Dec, 12:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17844
-
Michael Oehlhof updated the commit message in patch set 2 12/17/17, 23:41
-
TYPO3com voted on patch set 2 V -1 12/17/17, 23:41 Completed build in 08s on Mon, 18 Dec, 12:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17845
-
Michael Oehlhof uploaded patch set 3 12/18/17, 01:17
-
TYPO3com voted on patch set 3 V +1 12/18/17, 01:23 Completed build in 06m 38s on Mon, 18 Dec, 02:23 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17846
-
Stefan Neufeind commented on patch set 3 CR -1 12/18/17, 07:55
Even if there is a __PHP_Incomplete_Class the values are still already accessible. Can't we just read them directly instead to re-create the new execution-object, instead of doing the preg_replace-magic? -
Stefan Neufeind commented on patch set 3 CR 0 12/18/17, 08:12
tried a bit to access the properties directly, but they are protected. and throwing reflection at it might also not be a clean solution. I'm fine to continue with the review as-is. -
Mathias Brodala commented on patch set 3 12/18/17, 08:53
> tried a bit to access the properties directly, but they are > protected. and throwing reflection at it might also not be a clean > solution. I'm fine to continue with the review as-is. There are actually other ways to access protected/private properties aside from reflection which are way faster: https://ocramius.github.io/blog/accessing-private-php-class-members-without-reflection/ -
Mathias Schreiber commented on patch set 3 V -1 CR -1 02/11/18, 17:27
this approach (and the entire request to fix at all) comes with problems. So yes, we can regex stuff... We can also reflect ore Closure::Bind stuff. But here's the thing: At least PHP 7.2 lets you NOT call ANY method on an incomplete object. This means that we cannot reconstruct the serialized task, even if we wanted to. So with PHP 7.2 I deem this issue unsolvable. The only thing we can offer is to catch the broken tasks and delete them. Put up a flashmessage per deleted record and say "sorry". -
Mathias Schreiber commented on patch set 3 02/11/18, 17:28
Sidenote 2: Even if we were able to reconstruct the task, PHP will fatal if the class is no longer available on the system. -
Frank Nägler commented on patch set 3 CR -1 02/12/18, 13:00
I am here with Mattes. The only fix could/should be to catch the error and show a message about the problem and the possible fix, e.g. remove and re-add the task. An automatic update or migration has a really big impact. -
Frank Nägler uploaded patch set 4 02/12/18, 16:10
-
Christian Kuhn commented on patch set 3 CR -1 02/12/18, 16:10
actually, all of that is taken care if we don't try to automatically fix the string: if the task can't be unserialized, an error message is already rendered and the task is shown in a "The class of a registered task could not be found. You should re-install the extension that provided it or simply delete this task." table list with the option to delete it. we'll now just update the patch and fix only the .rst change. -
Christian Kuhn updated the commit message in patch set 5 02/12/18, 16:11
-
Frank Nägler voted on patch set 5 V +1 CR +1 02/12/18, 16:12
-
TYPO3com voted on patch set 4 V +1 02/12/18, 16:19 Completed build in 09m 18s on Mon, 12 Feb, 05:19 PM Test Summary: 30545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19379
-
TYPO3com voted on patch set 5 V +1 02/12/18, 16:21 Completed build in 10m 14s on Mon, 12 Feb, 05:21 PM Test Summary: 30545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19380
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/12/18, 16:27
-
Christian Kuhn merged patch set 6 02/12/18, 16:27