Review TYPO3_8-7 Merged

55143[BUGFIX] Make JS url encoding utf aware

Markus Klein CR +2 V +2 Easy +1 −1 updated 12/18/17, 10:29

Commit message

Replace the deprecated function JS `escape` with `encodeURIComponent`.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Markus Klein uploaded patch set 1 12/18/17, 09:32

  2. Markus Klein commented on patch set 1 12/18/17, 09:33

    Cherry Picked This patchset was cherry picked to branch master as commit 785ed1262e0cb51355eba8d1143732a7a583cc39
  3. Markus Klein commented on patch set 1 CR -2 12/18/17, 09:33

    has to wait for master patch
  4. TYPO3com voted on patch set 1 V +1 12/18/17, 09:48 Completed build in 15m 33s on Mon, 18 Dec, 10:48 AM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1560

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 12/18/17, 10:12

  6. Markus Klein voted on patch set 1 CR 0 12/18/17, 10:29

  7. Markus Klein voted on patch set 1 V +2 CR +2 12/18/17, 10:29

  8. Markus Klein merged patch set 2 12/18/17, 10:29