55144[BUGFIX] Make JS url encoding utf aware
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Daniel Huf +1
-
Verified V +2
- Andreas Kienast +2
- Daniel Huf +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Markus Klein commented on patch set 1 12/18/17, 09:33
Cherry Picked from branch TYPO3_8-7. -
TYPO3com voted on patch set 1 V +1 12/18/17, 09:41 Completed build in 08m 23s on Mon, 18 Dec, 10:41 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17847
-
Daniel Huf commented on patch set 1 V +1 CR +1 12/18/17, 10:02
Working for us, thanks -
Andreas Kienast voted on patch set 1 V +2 CR +2 12/18/17, 10:11
-
Andreas Kienast merged patch set 2 12/18/17, 10:11
-
Stephan Großberndt commented on patch set 2 12/18/17, 11:04
Nice catch! Backport to 7.6 too? -
Helmut Hummel commented on patch set 2 12/18/17, 11:42
post -1backend.js:43I guess these replacements are not needed any more then -
Markus Klein commented on patch set 2 12/18/17, 12:23
backend.js:43ReplyI'm pretty sure yes, but I kept them in place. We can remove them with a straight cleanup -
Stephan Großberndt commented on patch set 2 12/18/17, 12:32
backend.js:43Replyhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape#Description vs https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#Description escape does not escape @*_+-./ encodeURIComponent does not escape A-Z a-z 0-9 - _ . ! ~ * ' ( ) -
Markus Klein commented on patch set 2 12/18/17, 13:10
backend.js:43ReplySo remaining question is about the asterisk.