Review main Merged

55144[BUGFIX] Make JS url encoding utf aware

Markus Klein CR +2 V +2 Easy +1 −1 updated 12/18/17, 13:10

Commit message

Replace the deprecated function JS `escape` with `encodeURIComponent`.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Huf +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Huf +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Markus Klein commented on patch set 1 12/18/17, 09:33

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V +1 12/18/17, 09:41 Completed build in 08m 23s on Mon, 18 Dec, 10:41 AM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17847

  3. Daniel Huf commented on patch set 1 V +1 CR +1 12/18/17, 10:02

    Working for us, thanks
  4. Andreas Kienast voted on patch set 1 V +2 CR +2 12/18/17, 10:11

  5. Andreas Kienast merged patch set 2 12/18/17, 10:11

  6. Stephan Großberndt commented on patch set 2 12/18/17, 11:04

    Nice catch! Backport to 7.6 too?
  7. Helmut Hummel commented on patch set 2 12/18/17, 11:42

    post -1

    backend.js:43

    I guess these replacements are not needed any more then
  8. Markus Klein commented on patch set 2 12/18/17, 12:23

    backend.js:43 Reply

    I'm pretty sure yes, but I kept them in place. We can remove them with a straight cleanup
  9. Stephan Großberndt commented on patch set 2 12/18/17, 12:32

  10. Markus Klein commented on patch set 2 12/18/17, 13:10

    backend.js:43 Reply

    So remaining question is about the asterisk.