Review main Merged

55148[BUGFIX] Changelog install tool: Duplicate ids prevent expand

Christian Kuhn CR +2 V +2 Easy +9 −9 updated 12/19/17, 09:52

Commit message

Expand / collapse sections need a unique id to be properly
collapsible. The "Changelog documentation viewer" uses the
forge issue number for this, which is not unique.
The patch changes the id to use a prefix per version / section
and the loop interation index.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Alexander Opitz +1
  • Verified V +2
    • Georg Ringer +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/18/17, 15:13

  2. Christian Kuhn commented on patch set 1 12/18/17, 15:14

    Note: * this can be easily tested with the 7.6.x section - does not expand single files before, does expand the afterwards. * the v8 back port is likely a bit different. i'll push a separate version for that soon.
  3. TYPO3com voted on patch set 1 V +1 12/18/17, 15:22 Completed build in 08m 43s on Mon, 18 Dec, 04:22 PM Test Summary: 29975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17852

  4. Alexander Opitz commented on patch set 1 V +1 CR +1 12/18/17, 15:58

    Checked with "Breaking: #45899 - Split class ImportExport into classes Import and Export" in the 7.6 section. Which works after applying patch. Also other tested ones works
  5. Georg Ringer voted on patch set 1 V +2 CR +2 12/19/17, 09:52

  6. Georg Ringer merged patch set 2 12/19/17, 09:52