Review TYPO3_8-7 Merged

55150[BUGFIX] Changelog install tool: Duplicate ids prevent expand

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 12/19/17, 16:14

Commit message

Expand / collapse sections need a unique id to be properly
collapsible. The "Changelog documentation viewer" uses the
forge issue number for this, which is not unique.
The patch changes the id to use a prefix per version / section
and the loop interation index.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Opitz +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 12/18/17, 15:24

  2. TYPO3com voted on patch set 1 V +1 12/18/17, 15:33 Completed build in 08m 59s on Mon, 18 Dec, 04:33 PM Test Summary: 57787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1563

  3. Alexander Opitz voted on patch set 1 V +1 CR +1 12/18/17, 16:43

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 12/19/17, 16:14

  5. Christian Kuhn merged patch set 2 12/19/17, 16:14