Review main Merged

55164[BUGFIX] Use `new` in ReflectionServiceTest

Andreas Kienast CR +2 V +2 Easy +11 −15 updated 12/20/17, 15:31

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Sebastian Fischer +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Andreas Kienast uploaded patch set 1 12/19/17, 18:09

  2. TYPO3com voted on patch set 1 V +1 12/19/17, 18:16 Completed build in 07m 20s on Tue, 19 Dec, 07:16 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17905

  3. Anja Leichsenring commented on patch set 1 CR -1 12/19/17, 22:21

    You don't do anything with singletons in this test, so the backup and restore is not needed as far as I can see. Also, you don't test any non public functions, which makes the mock not necessary. If possible, system under test should always be a real instance. Better you settle for just swapping out the GU::makeInstance() calls for new() and drop the setUp() and tearDown() again.
  4. Andreas Kienast uploaded patch set 2 12/20/17, 07:00

  5. TYPO3com voted on patch set 2 V -1 12/20/17, 07:00 Completed build in 08s on Wed, 20 Dec, 08:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17915

  6. Andreas Kienast uploaded patch set 3 12/20/17, 07:01

  7. TYPO3com voted on patch set 3 V +1 12/20/17, 07:07 Completed build in 06m 39s on Wed, 20 Dec, 08:07 AM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17916

  8. Mathias Brodala commented on patch set 3 12/20/17, 07:10

    ReflectionServiceTest.php:48

    I'd say move this into setUp() and write it only once.
  9. Anja Leichsenring commented on patch set 3 CR +1 12/20/17, 07:18

    > Patch Set 3: > > (1 comment) Does the test now work locally, Andy?

    ReflectionServiceTest.php:48 Reply

    I'd rather leave it as is. A setUp() only for a new call makes little sense. So the whole test in one place - easier to read and to grasp.
  10. Andreas Kienast commented on patch set 3 12/20/17, 07:23

    @Anja: Everything is fine for me now.
  11. Anja Leichsenring voted on patch set 3 V +1 12/20/17, 07:25

  12. Sebastian Fischer voted on patch set 3 CR +1 12/20/17, 09:11

  13. Jörg Bösche voted on patch set 3 V +1 CR +1 12/20/17, 09:49

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 12/20/17, 15:31

  15. Andreas Kienast merged patch set 4 12/20/17, 15:31