Review main Merged

55170[FOLLOWUP][TASK] Streamline ExtensionManagementUtility

Anja Leichsenring CR +2 V +2 Easy +10 −14 updated 01/04/18, 17:13

Commit message

Remove a misleading match from the Extension Scanner matcher
configuration that caused a strong match for a false positive.

Also add a forgotten deprecation.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Sebastian Fischer +1
    • Reiner Teubner +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1318

  1. Anja Leichsenring uploaded patch set 1 12/19/17, 21:00

  2. TYPO3com voted on patch set 1 V +1 12/19/17, 21:07 Completed build in 07m 34s on Tue, 19 Dec, 10:07 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17910

  3. Mathias Brodala updated the commit message in patch set 2 12/20/17, 07:17

  4. Mathias Brodala commented on patch set 3 12/20/17, 07:19

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 12/20/17, 07:24 Completed build in 07m 00s on Wed, 20 Dec, 08:24 AM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17917

  6. TYPO3com voted on patch set 3 V +1 12/20/17, 07:27 Completed build in 07m 32s on Wed, 20 Dec, 08:27 AM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17918

  7. Benni Mack voted on patch set 3 V +1 CR +1 12/27/17, 04:33

  8. Christian Kuhn commented on patch set 3 CR -1 01/04/18, 12:52

    MethodCallStaticMatcher.php:473

    this one and the one above isn't correctly added, too, or is it?
  9. Anja Leichsenring uploaded patch set 4 01/04/18, 13:58

  10. Anja Leichsenring uploaded patch set 5 01/04/18, 13:59

  11. TYPO3com voted on patch set 4 V +1 01/04/18, 14:06 Completed build in 08m 11s on Thu, 4 Jan, 03:06 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18088

  12. TYPO3com voted on patch set 5 V +1 01/04/18, 14:07 Completed build in 08m 18s on Thu, 4 Jan, 03:07 PM Test Summary: 30005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18089

  13. Christian Kuhn voted on patch set 5 V +1 CR +1 01/04/18, 14:20

  14. Anja Leichsenring commented on patch set 5 01/04/18, 16:30

    there will be a dedicated required argument matcher for static methods with a different patch.
  15. Reiner Teubner voted on patch set 5 V +1 CR +1 01/04/18, 16:33

  16. Sebastian Fischer voted on patch set 5 CR +1 01/04/18, 16:47

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 01/04/18, 17:13

  18. Andreas Kienast merged patch set 6 01/04/18, 17:13