55186[FEATURE] Add enumeration for GeneralUtility::getIndpEnv()
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 116
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+3 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+6 −5
- typo3/sysext/backend/Classes/Controller/File/FileController.php+3 −2
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+2 −1
- typo3/sysext/backend/Classes/Controller/Wizard/ListController.php+2 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+2 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −4
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+2 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+4 −3
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −2
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+3 −2
- typo3/sysext/backend/Classes/Http/RequestHandler.php+2 −1
- typo3/sysext/backend/Classes/LoginProvider/UsernamePasswordLoginProvider.php+2 −1
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+2 −1
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+2 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+3 −2
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+2 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+2 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+2 −1
Show 96 more files
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+7 −6
- typo3/sysext/backend/Classes/View/PageLayoutView.php+17 −16
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+3 −2
- typo3/sysext/backend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+2 −1
- typo3/sysext/beuser/Classes/ViewHelpers/IssueCommandViewHelper.php+3 −2
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+2 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+16 −15
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+11 −10
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+6 −5
- typo3/sysext/core/Classes/Core/Bootstrap.php+5 −4
- typo3/sysext/core/Classes/Database/QueryView.php+2 −1
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+3 −2
- typo3/sysext/core/Classes/Error/ErrorHandler.php+2 −1
- typo3/sysext/core/Classes/Html/HtmlParser.php+2 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+7 −6
- typo3/sysext/core/Classes/Http/ServerRequestFactory.php+2 −1
- typo3/sysext/core/Classes/Log/Processor/WebProcessor.php+4 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+2 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+2 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+5 −4
- typo3/sysext/core/Classes/Type/Environment/EnvironmentVariable.php3new+49 −0
- typo3/sysext/core/Classes/Utility/ClientUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php3+87 −79
- typo3/sysext/core/Classes/Utility/PathUtility.php+4 −2
- typo3/sysext/core/Documentation/Changelog/7.2/Deprecation-65938-TSFEAnchorPrefix.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72686-RemovedRteHtmlParserMethods.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-83404-AddEnumerationForGeneralUtilitygetIndpEnv.rstnew+47 −0
- typo3/sysext/core/Resources/PHP/GlobalDebugFunctions.php+5 −2
- typo3/sysext/core/Tests/Unit/Log/Processor/WebProcessorTest.php+4 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+15 −14
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+5 −3
- typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.php+4 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+2 −1
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+5 −3
- typo3/sysext/extbase/Classes/Service/ImageService.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php+4 −2
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+2 −1
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+5 −4
- typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php+5 −4
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/DeleteFileViewHelper.php+2 −1
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/EditFileContentViewHelper.php+2 −1
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/EditSysFileMetadataRecordViewHelper.php+2 −1
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/RenameFileViewHelper.php+2 −1
- typo3/sysext/filelist/Classes/ViewHelpers/Uri/ReplaceFileViewHelper.php+2 −1
- typo3/sysext/filelist/Classes/FileList.php+2 −1
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestBuilder.php+3 −2
- typo3/sysext/fluid/Classes/View/StandaloneView.php+3 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+2 −1
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestBuilderTest.php+5 −2
- typo3/sysext/fluid/Tests/Unit/View/StandaloneViewTest.php+3 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+19 −18
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −1
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+3 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php+4 −3
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −1
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+4 −3
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+6 −5
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+4 −3
- typo3/sysext/frontend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+2 −1
- typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php+4 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+3 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −2
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −1
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+5 −2
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+3 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+5 −4
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+7 −6
- typo3/sysext/install/Classes/Controller/InstallerController.php+2 −1
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+3 −2
- typo3/sysext/install/Classes/Service/SessionService.php+2 −1
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+2 −1
- typo3/sysext/install/Classes/ViewHelpers/Uri/ActionViewHelper.php+4 −3
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php+2 −1
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+3 −2
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+2 −1
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+2 −1
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+2 −1
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+2 −1
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+2 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+5 −4
- typo3/sysext/recordlist/Classes/RecordList.php+3 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+2 −1
- typo3/sysext/rsaauth/Classes/RsaEncryptionEncoder.php+2 −1
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+2 −1
- typo3/sysext/scheduler/Classes/Example/TestTask.php+2 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+6 −5
- typo3/sysext/sys_note/Classes/ViewHelpers/DeleteLinkViewHelper.php+2 −1
- typo3/sysext/sys_note/Classes/ViewHelpers/EditLinkViewHelper.php+2 −1
- typo3/sysext/t3editor/Resources/Private/tsref.xml+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+3 −2
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+2 −1
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+4 −3
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+2 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+2 −1
- typo3/sysext/workspaces/Classes/Hook/PreviewHook.php+6 −5
- typo3/sysext/workspaces/Classes/Hook/TypoScriptFrontendControllerHook.php+3 −2
Review log 1725
-
Georg Ringer uploaded patch set 1 12/21/17, 07:24
-
TYPO3com voted on patch set 1 V -1 12/21/17, 07:25 Completed build in 20s on Thu, 21 Dec, 08:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17924
-
Mathias Brodala commented on patch set 1 12/21/17, 08:16
-
Georg Ringer uploaded patch set 2 12/21/17, 08:43
-
TYPO3com voted on patch set 2 V -1 12/21/17, 08:50 Completed build in 07m 15s on Thu, 21 Dec, 09:50 AM Test Summary: 562 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17925
-
Georg Ringer uploaded patch set 3 12/21/17, 09:28
-
TYPO3com voted on patch set 3 V -1 12/21/17, 09:36 Completed build in 07m 05s on Thu, 21 Dec, 10:36 AM Test Summary: 10 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17926
-
Georg Ringer uploaded patch set 4 12/21/17, 09:49
-
TYPO3com voted on patch set 4 V -1 12/21/17, 09:57 Completed build in 08m 35s on Thu, 21 Dec, 10:57 AM Test Summary: 3 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17927
-
Georg Ringer uploaded patch set 5 12/21/17, 10:00
-
TYPO3com voted on patch set 5 V -1 12/21/17, 10:10 Completed build in 09m 02s on Thu, 21 Dec, 11:10 AM Test Summary: 3 of 30142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17928
-
Georg Ringer uploaded patch set 6 12/21/17, 10:13
-
TYPO3com voted on patch set 6 V +1 12/21/17, 10:22 Completed build in 08m 50s on Thu, 21 Dec, 11:22 AM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17929
-
Mathias Brodala uploaded patch set 7 12/21/17, 14:25
-
Mathias Brodala commented on patch set 7 12/21/17, 14:26
Moved constants to enumeration. -
TYPO3com voted on patch set 7 V +1 12/21/17, 14:33 Completed build in 07m 41s on Thu, 21 Dec, 03:33 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17930
-
Jörg Bösche commented on patch set 7 V +1 CR +1 12/22/17, 07:37
Wow! Very good catch. Could not test every class, but with some smoke clicks/tests, everything looks fine. -
Andreas Wolf commented on patch set 7 12/22/17, 09:26
EnvironmentVariable.php:24_ARRAY is a weird name here; while we’re at it, we could probably rename this to _ALL?GeneralUtility.php:2544This TODO must be removed before merging! -
Mathias Brodala commented on patch set 7 12/22/17, 09:28
EnvironmentVariable.php:24ReplyI'm fine with renaming the constant but the value has to stay for now. Notice that "all" would be incorrect since you get a selected subset of all values.GeneralUtility.php:2544ReplyThis was meant as a reminder for https://review.typo3.org/55159 to be put here. -
Andreas Wolf uploaded patch set 8 12/22/17, 16:25
-
TYPO3com voted on patch set 8 V +1 12/22/17, 16:33 Completed build in 08m 17s on Fri, 22 Dec, 05:33 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17946
-
Andreas Wolf commented on patch set 7 12/22/17, 19:28
EnvironmentVariable.php:24ReplySure, the value must stay. As far as I understand, "_ARRAY" returns all the properties listed below, or did I miss something? -
Andreas Wolf voted on patch set 8 CR +1 12/22/17, 19:28
-
Helmut Hummel commented on patch set 8 CR -1 12/24/17, 12:50
rather than just introducing a new class that just acts as placeholder for strings, I would suggest to create a class (Environment) that is responsible for fetching and normalizing the environment at this point we may even decide to remove some things from getIndpEnv to other places like the server request, as many of the vars are in fact request related (like host name or request uri) -
Benni Mack abandoned the change 02/12/18, 20:12
hope it's ok. I'll abandon this change in favor of this approach, as Helmut pointed out: https://review.typo3.org/#/c/55506/
GeneralUtility.php:54