55187[BUGFIX] Add `controlsList` as known additional attribute
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Klein +1
Issues 1
Files 4
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+38 −51
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+38 −51
Review log 8
-
Stefan Neufeind uploaded patch set 1 12/21/17, 13:18
-
Stefan Neufeind commented on patch set 1 12/21/17, 13:19
hand-picked from 8.7 due to tests not cleanly cherry-picking -
Markus Klein voted on patch set 1 V +1 CR +1 12/21/17, 13:39
-
Jigal van Hemert voted on patch set 1 V +2 CR +2 12/21/17, 14:20
-
Jigal van Hemert merged patch set 2 12/21/17, 14:20
-
Jigal van Hemert commented on patch set 2 12/21/17, 14:21
Ehmm... is TYPO3.com not voting? -
Stephan Großberndt commented on patch set 2 12/21/17, 14:54
Fatal error: Call to undefined method TYPO3\CMS\Core\Tests\Unit\Resource\Rendering\AudioTagRendererTest::createMock() in /home/travis/build/TYPO3/TYPO3.CMS/typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php on line 109 -
Stephan Großberndt commented on patch set 2 12/21/17, 14:55