Review TYPO3_7-6 Merged

55189[BUGFIX] Use strict flag in signalslot dispatcher

Markus Klein CR +2 V +2 Easy +3 −1 updated 01/06/18, 16:21

Commit message

To avoid exceptions with complex structures, the strict flag
must be used in the in_array check.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Markus Klein commented on patch set 1 12/21/17, 13:32

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V +1 12/21/17, 13:39 Completed build in 06m 16s on Thu, 21 Dec, 02:39 PM Test Summary: 49014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1301

  3. Stefan Neufeind uploaded patch set 2 12/21/17, 13:49

  4. TYPO3com commented on patch set 2 12/21/17, 13:54 Completed build in 04m 56s on Thu, 21 Dec, 02:54 PM Test Summary: 49014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1302

  5. Markus Klein voted on patch set 2 V +2 CR +2 01/06/18, 16:21

  6. Markus Klein merged patch set 3 01/06/18, 16:21