Review main Abandoned

55190[BUGFIX] Keep width and height of translated file metadata

Christian Weiske CR 0 V 0 Easy +6 −0 updated 11/13/18, 17:23

Commit message

PageRepository->getRecordOverlay() unconditionally overwrites all
fields of a sys_file_metadata record, including width and height
- which are 0 for translated metadata records.

We simply reset them back to the original values, so that
cropping works again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1215

  1. Christian Weiske uploaded patch set 1 12/21/17, 14:54

  2. TYPO3com voted on patch set 1 V +1 12/21/17, 15:01 Completed build in 07m 20s on Thu, 21 Dec, 04:01 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17932

  3. Frans Saris commented on patch set 1 CR +1 12/30/17, 07:40

    The origin of the wrong data in the DB is fixed already in master and 8.7 branch. The TCA was incorrect as a result width and height weren't synced correctly for translations by the datahandler. So this is only a fallback for wrong DB data.
  4. Oliver Klee commented on patch set 1 12/30/17, 11:07

    FileMetadataOverlayAspect.php:50

    Can we use strict comparison here (===)?
  5. Christian Weiske commented on patch set 1 12/30/17, 11:11

    > (1 comment) I'm not sure that the 0 is always cast to int, which is why I did not use === there.
  6. Oliver Klee commented on patch set 2 12/30/17, 11:13

    Published edit on patch set 1.
  7. Oliver Klee commented on patch set 3 12/30/17, 11:14

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 2 V +1 12/30/17, 11:21 Completed build in 07m 25s on Sat, 30 Dec, 12:21 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18003

  9. TYPO3com voted on patch set 3 V +1 12/30/17, 11:24 Completed build in 09m 40s on Sat, 30 Dec, 12:24 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18004

  10. Tobi Kretschmann voted on patch set 3 CR +1 01/08/18, 10:01

  11. Jörg Bösche voted on patch set 3 CR +1 01/08/18, 10:24

  12. Tymoteusz Motylewski commented on patch set 3 01/09/18, 20:47

    If this is only a fallback, maybe a better idea is to create a install tool wizzard which will fix the data in the db instead? I'm afraid that in some time we will not remember why this code was added.
  13. Stefan Neufeind commented on patch set 3 CR -1 01/15/18, 07:45

    I'm also in favor of fixing old/wrong data instead of the suggested fallback.
  14. Christian Weiske abandoned the change 01/15/18, 16:00

  15. Helmut Hummel commented on patch set 3 11/13/18, 17:23

    The reasons for this are not fully fixed. See my comments in Forge explaining that this can still happen for editors