55192[BUGFIX] Add support for PNG icons of the SVG Tree
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Benni Mack uploaded patch set 1 12/21/17, 16:31
-
TYPO3com voted on patch set 1 V +1 12/21/17, 16:40 Completed build in 08m 39s on Thu, 21 Dec, 05:40 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17933
-
Frans Saris commented on patch set 1 CR +1 12/21/17, 18:22
Benni do you have a test ext to verify this? -
Frans Saris commented on patch set 1 12/21/17, 18:23
Or just a code snippet -
Daniel Gorges voted on patch set 1 V +1 CR +1 12/22/17, 13:43
-
Benni Mack commented on patch set 1 12/27/17, 07:45
Simply change the TCA type of "typeicon_classes[1]" in your TCA/pages.php to "flags-multiple" (which is a PNG) -
Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 07:49
-
Tymoteusz Motylewski commented on patch set 1 12/29/17, 23:11
SvgTree.js:443shouldnt it be also /<image[\s\S]*\/>/i to match tag splitted in multiple lines? -
Tymoteusz Motylewski commented on patch set 2 12/30/17, 19:22
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 12/30/17, 19:28 Completed build in 06m 45s on Sat, 30 Dec, 08:28 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18007
-
Andreas Kienast voted on patch set 2 V +1 CR +1 01/01/18, 19:50
-
Georg Ringer voted on patch set 2 V +2 CR +2 01/02/18, 08:22
-
Georg Ringer merged patch set 3 01/02/18, 08:22