Review main Merged

55202[BUGFIX] Don’t show deprecations as "success" flash messages

Andreas Wolf CR +2 V +2 Easy +5 −1 updated 01/02/18, 13:39

Commit message

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • Reiner Teubner +1
  • Verified V +2
    • Andreas Wolf +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Andreas Wolf uploaded patch set 1 12/22/17, 16:13

  2. TYPO3com voted on patch set 1 V +1 12/22/17, 16:20 Completed build in 06m 26s on Fri, 22 Dec, 05:20 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17945

  3. Georg Ringer voted on patch set 1 V +1 CR +1 01/02/18, 08:23

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 01/02/18, 08:44

  5. Jörg Bösche commented on patch set 1 V +1 CR +1 01/02/18, 09:25

    Reproduction/Testing: 1. Open EditDocumentController 2. Add "trigger_error('foo');" in mainAction() 3. Edit an item on page 4. Green flash message with an error occurs. After applying the patch, the error message is displayed correctly.
  6. Reiner Teubner voted on patch set 1 V +1 CR +1 01/02/18, 13:37

  7. Andreas Wolf voted on patch set 1 V +2 CR +2 01/02/18, 13:39

  8. Andreas Wolf merged patch set 2 01/02/18, 13:39