Review main Merged

55203[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Mathias Brodala CR +2 V +2 Easy +7 −5 updated 02/10/18, 20:51

Commit message

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2127

Show 12 earlier messages
  1. Mathias Brodala uploaded patch set 1 12/22/17, 16:50

  2. TYPO3com voted on patch set 1 V +1 12/22/17, 16:58 Completed build in 07m 42s on Fri, 22 Dec, 05:58 PM Test Summary: 29981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17949

  1. anonymized-61094 commented on patch set 1 12/23/17, 22:50

  2. Mathias Brodala uploaded patch set 2 01/04/18, 08:45

  3. TYPO3com voted on patch set 2 V +1 01/04/18, 08:53 Completed build in 08m 38s on Thu, 4 Jan, 09:53 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18057

  4. Andreas Kienast voted on patch set 2 CR +1 01/04/18, 09:11

  5. Daniel Gohlke voted on patch set 2 CR +1 01/15/18, 10:09

  6. Daniel Gohlke commented on patch set 2 V -1 CR 0 01/15/18, 10:13

    MultiCheckbox still needs an iterator + iterator.cycle per each for sequence as the uniqueIdentifier is always the same in the MultiCheckbox partial. Same for RadioButton where each option needs another ID (as both traverse over the properties.options).
  7. Daniel Gohlke commented on patch set 2 01/15/18, 10:19

    Problem for multi checkboxes and radios is the the same HTML id. Merging this patch will cause the same error in chrome too. Clicking the label isn't possible.
  8. Björn Jacob commented on patch set 2 V -1 01/15/18, 10:39

    IMHO this patch will cause new issues. This kind feels like a feature. I would recommend not having template changes in v8 anymore. This caused to much trouble during the last minor releases of v8. Let's think of a more sophisticated solution for v9.
  9. Mathias Brodala commented on patch set 2 01/15/18, 10:42

    > IMHO this patch will cause new issues. This kind feels like a > feature. I would recommend not having template changes in v8 > anymore. This caused to much trouble during the last minor releases > of v8. Let's think of a more sophisticated solution for v9. It's definitely not a feature since it, well, fixes a bug. Unless you count support for IE/Edge as feature. ;-) Personally I don't mind limiting this to v9 though.
  10. Björn Jacob commented on patch set 2 01/15/18, 11:25

    Okay, then "TASK" for v9 only?
  11. Mathias Brodala commented on patch set 2 01/15/18, 11:26

    > Okay, then "TASK" for v9 only? Fine with me.
  12. anonymized-61094 commented on patch set 2 01/15/18, 18:22

    > Patch Set 2: > > Problem for multi checkboxes and radios is the the same HTML id. Merging this patch will cause the same error in chrome too. Clicking the label isn't possible. Well that's why I wrote https://review.typo3.org/c/55203/#message-c181f4ef_eb2d807f which fixes it in all browser. ;-) Do you need the partials that we use in our project where we use an iterator combined with the ID?
  13. anonymized-61094 commented on patch set 2 01/15/18, 18:22

    > Patch Set 2: > > > Okay, then "TASK" for v9 only? > > Fine with me. So forms for Edge and IE11 are broken so far?
  14. Björn Jacob commented on patch set 2 01/15/18, 18:34

    @Daniel Ruf: would not hurt to see your solution, sure :) In fact, IE and Edge are broken and not the form framework ;) As already mentioned, I am not happy with changing the templates for a LTS version.
  15. Mathias Schreiber uploaded patch set 3 02/10/18, 17:47

  16. Mathias Schreiber uploaded patch set 4 02/10/18, 17:48

  17. Mathias Schreiber uploaded patch set 5 02/10/18, 17:49

  18. Mathias Schreiber commented on patch set 5 V +1 CR +1 02/10/18, 17:50

    This should do the job. I can totally live with changed in v8 templates. After all: people that overrode them are not affected and people that did not now get clickable links. If there is a usecase I completely miss, tell me :)
  19. TYPO3com voted on patch set 3 V +1 02/10/18, 17:56 Completed build in 09m 05s on Sat, 10 Feb, 06:56 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19297

  20. TYPO3com voted on patch set 4 V +1 02/10/18, 17:58 Completed build in 10m 04s on Sat, 10 Feb, 06:58 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19298

  21. TYPO3com voted on patch set 5 V -1 02/10/18, 17:59 Completed build in 09m 51s on Sat, 10 Feb, 06:59 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19299

  22. TYPO3com voted on patch set 5 V +1 02/10/18, 18:03 Completed build in 23m 48s on Sat, 10 Feb, 07:03 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19299

  23. Anja Leichsenring commented on patch set 5 V +1 CR +1 02/10/18, 20:14

    +1 for backport, too. Clickable labels for *boxes are quite important.
  24. Benni Mack voted on patch set 5 V +2 CR +2 02/10/18, 20:51

  25. Benni Mack merged patch set 6 02/10/18, 20:51