Review main Merged

55213[BUGFIX] Make full search in lowlevel module work again

Benni Mack CR +2 V +2 Normal +48 −27 updated 01/04/18, 08:41

Commit message

Due to the refactoring the advanced query functionality was broken and not
tested anymore.

The patch minimizes the functionality on the $GLOBALS['SOBE'] code again.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Reiner Teubner +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1822

  1. Benni Mack uploaded patch set 1 12/27/17, 10:48

  2. TYPO3com voted on patch set 1 V +1 12/27/17, 10:55 Completed build in 07m 11s on Wed, 27 Dec, 11:55 AM Test Summary: 29987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17961

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 12/27/17, 11:01

  4. Anja Leichsenring rebased onto patch set 2 12/28/17, 11:12

  5. TYPO3com voted on patch set 2 V +1 12/28/17, 11:20 Completed build in 07m 22s on Thu, 28 Dec, 12:20 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17988

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/28/17, 12:17

  7. Reiner Teubner voted on patch set 2 V +1 CR +1 01/02/18, 11:36

  8. Benjamin Kluge commented on patch set 2 CR -1 01/02/18, 12:36

    QueryView.php:98

    menuItems are not used in this patch. Maybe not needed?

    QueryView.php:103

    moduleName are not used in this patch. Maybe not needed?
  9. Anja Leichsenring commented on patch set 2 01/02/18, 12:46

    > Patch Set 2: Code-Review-1 > > (2 comments)

    QueryView.php:98 Reply

    used in line 405

    QueryView.php:103 Reply

    used in line 407
  10. Benjamin Kluge voted on patch set 2 V +1 CR +1 01/02/18, 12:52

  11. Alexander Opitz commented on patch set 2 01/02/18, 14:54

    QueryView.php:1208

    Should we also get rid of this mixed usage? $SET vs. $this->settings?
  12. Reiner Teubner rebased onto patch set 3 01/03/18, 17:01

  13. TYPO3com voted on patch set 3 V +1 01/03/18, 17:11 Completed build in 10m 05s on Wed, 3 Jan, 06:11 PM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18039

  14. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/03/18, 20:03

  15. Anja Leichsenring commented on patch set 3 01/03/18, 20:04

    > Patch Set 2: > > (1 comment) yepp, we should. But this is not scope of this patch. It is a bugfix, no refactoring.
  16. Reiner Teubner voted on patch set 3 V +1 CR +1 01/04/18, 08:25

  17. Andreas Kienast updated the commit message in patch set 4 01/04/18, 08:27

  18. Anja Leichsenring voted on patch set 4 V +1 CR +1 01/04/18, 08:29

  19. Reiner Teubner voted on patch set 4 V +1 CR +1 01/04/18, 08:29

  20. TYPO3com voted on patch set 4 V +1 01/04/18, 08:38 Completed build in 11m 17s on Thu, 4 Jan, 09:38 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18055

  21. Andreas Kienast voted on patch set 4 V +2 CR +2 01/04/18, 08:41

  22. Andreas Kienast merged patch set 5 01/04/18, 08:41